Add a Mac Catalyst XCFramework slice#14
Open
ReessKennedy wants to merge 2 commits into
Open
Conversation
- add mac catalyst xcframework variants for arm64 and x86_64 - update CLibsql packaging metadata for maccatalyst - add a helper build script path for catalyst slice generation
- replace duplicate per-arch catalyst entries with one universal catalyst slice - update xcframework metadata to advertise a single maccatalyst library definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This adds a Mac Catalyst slice to
Sources/CLibsql/CLibsql.xcframeworkand updates the packaging metadata to advertise it as a singleios-arm64_x86_64-maccatalystlibrary definition.It also updates the local
Sources/CLibsql/build.shhelper toward the same goal by documenting the Catalyst-specific build path we used while validating the slice.Why
libsql-swiftalready ships iOS, iOS Simulator, and macOS slices, but not a Mac Catalyst slice. In downstream testing, that prevented the package from being used in a Catalyst target even though the Swift layer itself was otherwise compatible.Adding a Catalyst XCFramework slice makes the package resolvable from a Catalyst app target and unblocks basic runtime smoke tests there.
Impact
Libsqlfrom a Mac Catalyst target.Validation
aarch64-apple-ios-macabiandx86_64-apple-ios-macabistatic librariesmaccatalystdefinition