feat: make schema/is_schema optional

Author: notrab

src/database.test.ts

@@ -22,4 +22,20 @@ describe("DatabaseClient", () => {
       } as unknown as (typeof client.create.arguments)[1])
     ).rejects.toThrow("'is_schema' and 'schema' cannot both be provided");
   });
+
+  it('throws error if seed type is "database" and name is missing', async () => {
+    const options = { seed: { type: "database" } };
+    // @ts-expect-error
+    await expect(client.create("testDB", options)).rejects.toThrow(
+      "Seed name is required when type is 'database'"
+    );
+  });
+
+  it('throws error if seed type is "dump" and url is missing', async () => {
+    const options = { seed: { type: "dump" } };
+    // @ts-expect-error
+    await expect(client.create("testDB", options)).rejects.toThrow(
+      "Seed URL is required when type is 'dump'"
+    );
+  });
 });

src/database.ts

@@ -72,7 +72,20 @@ export interface DatabaseInstance {
 
 type MultiDBSchemaOptions =
   | { is_schema: boolean; schema?: never }
-  | { is_schema?: never; schema: string };
+  | { is_schema?: never; schema: string }
+  | {};
+
+function hasIsSchemaOption(
+  options: any
+): options is { is_schema: boolean; schema?: never } {
+  return options !== undefined && options.is_schema !== undefined;
+}
+
+function hasSchemaOption(
+  options: any
+): options is { is_schema?: never; schema: string } {
+  return options !== undefined && options.schema !== undefined;
+}
 
 export class DatabaseClient {
   constructor(private config: TursoConfig) {}
@@ -106,7 +119,7 @@ export class DatabaseClient {
       };
     } & MultiDBSchemaOptions
   ): Promise<DatabaseCreateResponse> {
-    if (options?.is_schema !== undefined && options?.schema !== undefined) {
+    if (hasIsSchemaOption(options) && hasSchemaOption(options)) {
       throw new Error("'is_schema' and 'schema' cannot both be provided");
     }