Respond to PR check-in comment#1016
Closed
Copilot wants to merge 17 commits into
Closed
Conversation
When users upload databases >1GB while authenticated with a JWT token, show a warning that JWTs are short-lived and may expire during long transfers. Recommend using API tokens instead and show how to create one. The warning can be skipped with --yes flag or by setting TURSO_API_TOKEN.
When importing large database files with `turso db import`, the SQLite validation step (pragma quick_check) would make the CLI appear hung. This adds a spinner with percentage progress during validation. - Use sqlite3's `.progress N` command to get periodic callbacks - Dynamically adjust callback interval based on file size (~100 updates) - Cap progress at 99% until validation completes (estimate may overshoot) - Add SpinnerInterface for testability - Add comprehensive tests for the new functionality 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Instead of hardcoding a 1-hour expiration for upload tokens, calculate the expiration based on file size assuming 10 MB/s minimum upload speed plus a 1-hour buffer for server-side validation. This fixes uploads failing mid-transfer for large databases (e.g., 93GB) when the 1-hour token expires before the upload completes. Also removes the misleading JWT expiration warning that suggested using API tokens, since the upload always creates a JWT regardless of how the user authenticated.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Chunks now retry up to 3 times with exponential backoff on transient failures (5xx, network errors, 408, 429). Token is refreshed on each retry attempt to prevent expiration during long retry sequences. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Copilot
AI
changed the title
[WIP] Improve multipart upload flow with various enhancements
Respond to PR check-in comment
Jan 9, 2026
Contributor
Author
The CI is using the old version because the PR #1015 was merged to |
LeMikaelF
force-pushed
the
multipart-improvements
branch
from
f5722c6 to
be8d425
Compare
Contributor
|
This is a dummy PR. I tagged copilot and it opened a PR, I used it just for discussing my problem and it spotted the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acknowledged availability in response to @LeMikaelF's check-in comment on the multipart upload improvements PR. No code changes were required as all existing comment threads are either resolved or informational.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.