Fix version in turso group list output#982
Merged
Merged
Conversation
The `tech-preview` version is just something the API returns for historical reasons. Therefore, output "turso-server" instead to avoid confusing people.
avinassh
approved these changes
Jun 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the groupsTable function to display "turso-server" instead of the historical "tech-preview" API version, reducing confusion for end users.
- Introduces a local
versionvariable with a conditional override for"tech-preview". - Updates the table row construction to use the new
versionvalue.
Comments suppressed due to low confidence (2)
internal/cmd/group.go:224
- [nitpick] Consider renaming the local variable
versiontodisplayVersionoroutputVersionto avoid shadowinggroup.Versionand clarify its purpose.
version := "turso-server"
internal/cmd/group.go:224
- Add a unit test for the
groupsTablefunction to verify that whengroup.Versionis"tech-preview", the output row uses"turso-server"as expected.
version := "turso-server"
notrab
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tech-previewversion is just something the API returns for historical reasons. Therefore, output "turso-server" instead to avoid confusing people.