Sync is breaking with UPDATE statements

[avinassh]

Right now, ER/OS does lazy sync i.e. once you make writes they are not pulled immediately rather on next select. However, AlCapone reports that if you do UPDATE and then SELECT the changes are not pulled

reproduction - https://github.com/khuezy/libsql_bug/blob/e0ad25f/index.ts#L69

discord - https://discord.com/channels/933071162680958986/1400647192431169617/1406420589400555621

[khuezy]

The changes are pulled for normal executes, but they aren't pulled when the prior queries are wrapped in a transaction

[penberg]

AFAICT, the lazy pull optimization is incorrect because it sets the "needs_pull" flag once in prepare(), which is wrong as statements can be reused. I posted a libSQL PR to remove the optimization altogether.

[penberg]

@avinassh @khuezy I just released @libsql/client version v0.15.13, which removes the broken lazy pull optimization. Apps can still control pull behavior with the "read your write" flag, but when it's set to true, the library pulls after every write to ensure correctness.

[khuezy]

@penberg will the optimization be reintroduced later? IIRC it did increase perf a bit.

[penberg]

Hey @khuezy, not sure yet, depends if we figure out how to do it safely.