Remove another clone, fix clippy

Author: PThorpe92

core/mvcc/cursor.rs

@@ -368,7 +368,7 @@ impl<Clock: LogicalClock + 'static> MvccLazyCursor<Clock> {
             MvccCursorType::Table => None,
         };
         self.db
-            .read_from_table_or_index(self.tx_id, &row_id, maybe_index_id)
+            .read_from_table_or_index(self.tx_id, row_id, maybe_index_id)
     }
 
     pub fn close(self) -> Result<()> {
@@ -1485,7 +1485,7 @@ impl<Clock: LogicalClock + 'static> CursorTrait for MvccLazyCursor<Clock> {
 
     fn count(&mut self) -> Result<IOResult<usize>> {
         loop {
-            let state = self.count_state.clone();
+            let state = self.count_state;
             match state {
                 None => {
                     self.count_state.replace(CountState::Rewind);

core/mvcc/database/mod.rs

@@ -482,8 +482,8 @@ impl Transaction {
         }
     }
 
-    fn insert_to_read_set(&self, id: &RowID) {
-        self.read_set.insert(id.clone());
+    fn insert_to_read_set(&self, id: RowID) {
+        self.read_set.insert(id);
     }
 
     fn insert_to_write_set(&self, id: RowID) {
@@ -2630,7 +2630,7 @@ impl<Clock: LogicalClock> MvStore<Clock> {
                         .rev()
                         .find(|rv| rv.is_visible_to(tx, &self.txs))
                     {
-                        tx.insert_to_read_set(id);
+                        tx.insert_to_read_set(id.clone());
                         return Ok(Some(rv.row.clone()));
                     }
                 }

core/mvcc/database/tests.rs

@@ -1940,7 +1940,7 @@ fn test_delete_nonexistent() {
         .mvcc_store
         .delete(
             tx,
-            &RowID {
+            RowID {
                 table_id: (-2).into(),
                 row_id: RowKey::Int(1)
             },
@@ -2161,7 +2161,7 @@ fn test_dirty_read_deleted() {
         .mvcc_store
         .delete(
             tx2,
-            &RowID {
+            RowID {
                 table_id: (-2).into(),
                 row_id: RowKey::Int(1)
             },

core/mvcc/persistent_storage/logical_log.rs

@@ -1580,7 +1580,7 @@ mod tests {
         let mvcc_store = db.get_mvcc_store();
         for (rowid, value) in &values {
             let tx = mvcc_store.begin_tx(pager.clone()).unwrap();
-            let row = mvcc_store.read(tx, &rowid).unwrap().unwrap();
+            let row = mvcc_store.read(tx, rowid).unwrap().unwrap();
             let record = ImmutableRecord::from_bin_record(row.payload().to_vec());
             let foo = record.iter().unwrap().next().unwrap().unwrap();
             let ValueRef::Text(foo) = foo else {