core/storage: Some fallible allocations for sqlite3_ondisk.rs#7398
Open
pedrocarlo wants to merge 2 commits into
Open
core/storage: Some fallible allocations for sqlite3_ondisk.rs#7398pedrocarlo wants to merge 2 commits into
sqlite3_ondisk.rs#7398pedrocarlo wants to merge 2 commits into
Conversation
pedrocarlo
requested review from
jussisaurio,
penberg and
pereman2
as code owners
pedrocarlo
changed the title
sqlite3_ondisk.rs
penberg
changed the title
sqlite3_ondisk.rssqlite3_ondisk.rs
jussisaurio
reviewed
Jun 8, 2026
| if run_start_id.is_none() { | ||
| run_start_id = Some(*id); | ||
| } | ||
| // Most likely Preallocated enough to not use `try_push. |
Collaborator
Author
There was a problem hiding this comment.
this is mainly me being skeptical about the let mut run_bufs = fail_run_if_err!(Vec::try_with_capacity_ext(EST_BUFF_CAPACITY)); preallocation. It seems to be an estimated capacity and I was trying to avoid a try_push call here which is slower. We could IMO, force a max amount of pages we can have in a single vectored read, which would make the preallocation exact. But I did not do this here, as this PR is supposed to be more mechanical in nature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds some more fallible allocations in
sqlite3_ondisk.rsMotivation and context
Fallible allocations
Description of AI Usage
Not much, just to verify my work a bit