Skip to content

The example should compare uploadChunk() against -1 #36

@peter-lyons-kehl

Description

@peter-lyons-kehl

https://github.com/tus/tus-android-client/blob/master/example/src/main/java/io/tus/android/example/MainActivity.java#L166 loops while(!isCancelled() && uploader.uploadChunk() > 0). However, according to https://github.com/tus/tus-java-client/blob/master/src/main/java/io/tus/java/client/TusUploader.java#L18 and https://github.com/tus/tus-java-client/blob/master/src/main/java/io/tus/java/client/TusUploader.java#L182, uploadChunk() may return 0 while the upload is not finished yet (for example, while the connection is down?).

Please fix the example to loop while(!isCancelled() && uploader.uploadChunk() > 1) instead.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions