Drop node: protocol for importing Node.js modules (#720)

Author: Marius

biome.json

@@ -18,7 +18,8 @@
       "style": {
         "noParameterAssign": "warn",
         "noDefaultExport": "warn",
-        "useCollapsedElseIf": "error"
+        "useCollapsedElseIf": "error",
+        "useNodejsImportProtocol": "off"
       },
       "suspicious": {
         "noExplicitAny": "warn",

demos/cordova/hooks/before_prepare/copy_tus_files.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 
-const fs = require('node:fs')
-const path = require('node:path')
+const fs = require('fs')
+const path = require('path')
 
 const rootDir = path.join(__dirname, '..', '..')
 const tusJsPath = path.join(rootDir, '..', '..', 'dist', 'tus.js')

demos/nodejs/index.js

@@ -1,4 +1,4 @@
-const fs = require('node:fs')
+const fs = require('fs')
 const tus = require('../..')
 
 const path = `${__dirname}/../../README.md`

lib/node/fileReader.js

@@ -1,4 +1,4 @@
-import { ReadStream } from 'node:fs'
+import { ReadStream } from 'fs'
 import isStream from 'is-stream'
 
 import BufferSource from './sources/BufferSource.js'

lib/node/fileSignature.js

@@ -1,6 +1,6 @@
-import { createHash } from 'node:crypto'
-import * as fs from 'node:fs'
-import * as path from 'node:path'
+import { createHash } from 'crypto'
+import * as fs from 'fs'
+import * as path from 'path'
 
 /**
  * Generate a fingerprint for a file which will be used the store the endpoint

lib/node/httpStack.js

@@ -1,9 +1,9 @@
 // The url.parse method is superseeded by the url.URL constructor,
 // but it is still included in Node.js
-import * as http from 'node:http'
-import * as https from 'node:https'
-import { Readable, Transform } from 'node:stream'
-import { parse } from 'node:url'
+import * as http from 'http'
+import * as https from 'https'
+import { Readable, Transform } from 'stream'
+import { parse } from 'url'
 import throttle from 'lodash.throttle'
 
 export default class NodeHttpStack {

lib/node/sources/FileSource.js

@@ -1,4 +1,4 @@
-import { createReadStream, promises as fsPromises } from 'node:fs'
+import { createReadStream, promises as fsPromises } from 'fs'
 
 export default async function getFileSource(stream) {
   const path = stream.path.toString()

lib/node/urlStorage.js

@@ -1,4 +1,4 @@
-import { readFile, writeFile } from 'node:fs'
+import { readFile, writeFile } from 'fs'
 import combineErrors from 'combine-errors'
 import * as lockfile from 'proper-lockfile'
 

test/spec/test-node-specific.js

@@ -1,11 +1,11 @@
-const stream = require('node:stream')
+const stream = require('stream')
 const temp = require('temp')
-const fs = require('node:fs')
-const https = require('node:https')
-const http = require('node:http')
-const crypto = require('node:crypto')
+const fs = require('fs')
+const https = require('https')
+const http = require('http')
+const crypto = require('crypto')
 const intoStream = require('into-stream')
-const { once } = require('node:events')
+const { once } = require('events')
 const tus = require('../..')
 const assertUrlStorage = require('./helpers/assertUrlStorage')
 const { TestHttpStack, waitableFunction } = require('./helpers/utils')