Skip to content

Commit c9f1b2d

Browse files
committed
made get and set headers case insensitive as per http1.1 spec
1 parent faf83f6 commit c9f1b2d

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

lib/browser/FetchHttpStack.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class FetchRequest implements HttpRequest {
4242
}
4343

4444
getHeader(header: string) {
45-
return this._headers[header]
45+
return this._headers[header.toLowerCase()]
4646
}
4747

4848
setProgressHandler(_progressHandler: HttpProgressHandler): void {
@@ -93,7 +93,7 @@ class FetchResponse implements HttpResponse {
9393
}
9494

9595
getHeader(header: string): string | undefined {
96-
return this._res.headers.get(header) || undefined
96+
return this._res.headers.get(header.toLowerCase()) || undefined
9797
}
9898

9999
getBody(): string {

lib/browser/XHRHttpStack.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,13 @@ class XHRRequest implements HttpRequest {
4242
}
4343

4444
setHeader(header: string, value: string): void {
45+
header = header.toLowerCase()
4546
this._xhr.setRequestHeader(header, value)
4647
this._headers[header] = value
4748
}
4849

4950
getHeader(header: string): string {
50-
return this._headers[header]
51+
return this._headers[header.toLowerCase()]
5152
}
5253

5354
setProgressHandler(progressHandler: HttpProgressHandler): void {
@@ -112,7 +113,7 @@ class XHRResponse implements HttpResponse {
112113
}
113114

114115
getHeader(header: string): string | undefined {
115-
return this._xhr.getResponseHeader(header) || undefined
116+
return this._xhr.getResponseHeader(header.toLowerCase()) || undefined
116117
}
117118

118119
getBody(): string {

lib/node/NodeHttpStack.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ class Request implements HttpRequest {
5858
}
5959

6060
setHeader(header: string, value: string) {
61-
this._headers[header] = value
61+
this._headers[header.toLowerCase()] = value
6262
}
6363

6464
getHeader(header: string) {
65-
return this._headers[header]
65+
return this._headers[header.toLowerCase()]
6666
}
6767

6868
setProgressHandler(progressHandler: HttpProgressHandler) {

test/spec/helpers/utils.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,11 @@ export class TestRequest {
9696
}
9797

9898
setHeader(header, value) {
99-
this.requestHeaders[header] = value
99+
this.requestHeaders[header.toLowerCase()] = value
100100
}
101101

102102
getHeader(header) {
103-
return this.requestHeaders[header] || null
103+
return this.requestHeaders[header.toLowerCase()] || null
104104
}
105105

106106
setProgressHandler(progressHandler) {
@@ -184,7 +184,7 @@ export class TestResponse {
184184
}
185185

186186
getHeader(header) {
187-
return this._response.responseHeaders[header]
187+
return this._response.responseHeaders[header.toLowerCase()]
188188
}
189189

190190
getBody() {

0 commit comments

Comments
 (0)