Announce to client that FileStore supports termination extension (#261)

Author: mitjap

lib/stores/DataStore.js

@@ -42,6 +42,10 @@ class DataStore extends EventEmitter {
         this._extensions = extensions_array;
     }
 
+    hasExtension(extension) {
+        return this._extensions.indexOf(extension) !== -1;
+    }
+
     /**
      * Called in POST requests. This method just creates a
      * file, implementing the creation extension.

lib/stores/FileStore.js

@@ -26,7 +26,7 @@ class FileStore extends DataStore {
         super(options);
         this.directory = options.directory || options.path.replace(/^\//, '');
 
-        this.extensions = ['creation', 'creation-with-upload', 'creation-defer-length'];
+        this.extensions = ['creation', 'creation-with-upload', 'creation-defer-length', 'termination'];
         this.configstore = new Configstore(`${pkg.name}-${pkg.version}`);
         this._checkOrCreateDirectory();
     }

test/Test-DataStore.js

@@ -41,6 +41,16 @@ describe('DataStore', () => {
         done();
     });
 
+    it('should check for an extension', (done) => {
+        datastore.extensions = [ 'creation', 'expiration'];
+        assert.equal(datastore.hasExtension('creation'), true);
+        assert.equal(datastore.hasExtension('expiration'), true);
+
+        assert.equal(datastore.hasExtension('concatentation'), false);
+        assert.equal(datastore.hasExtension('CREATION'), false); // test case sensitivity
+        done();
+    });
+
     it('must have a create method', (done) => {
         datastore.should.have.property('create');
         datastore.create.should.be.type('function');

test/Test-Stores.shared.js

@@ -50,6 +50,10 @@ exports.shouldCreateUploads = function () {
       url: this.storePath,
     }
 
+    it('should report \'creation\' extension', function () {
+      assert.equal(this.server.datastore.hasExtension('creation'), true);
+    })
+
     it('should reject if both upload-length and upload-defer-length are not provided', function (done) {
       assert.rejects(() => this.server.datastore.create(invalidReq))
       done()
@@ -88,6 +92,10 @@ exports.shouldCreateUploads = function () {
 
 exports.shouldRemoveUploads = function () {
   describe('remove (termination extension)', function () {
+    it('should report \'termination\' extension', function () {
+      assert.equal(this.server.datastore.hasExtension('termination'), true);
+    })
+
     it('should reject when the file does not exist', function () {
       const req = { file_id: '1234' }
       return this.server.datastore.remove(req).should.be.rejected()