@tus/s3-store: fix uncaught exception when cancelling an upload (#412)

naumf · web-flow · commit 6fc2255cf533 · 2023-03-14T21:59:47.000+08:00
diff --git a/packages/s3-store/index.ts b/packages/s3-store/index.ts
@@ -262,11 +262,13 @@ export class S3Store extends DataStore {
               ])
             }
 
+            const readable = fs.createReadStream(path)
+            readable.on('error', reject)
             if (partSize > this.minPartSize || isFinalChunk) {
-              await this.uploadPart(metadata, fs.createReadStream(path), partNumber)
+              await this.uploadPart(metadata, readable, partNumber)
               offset += partSize
             } else {
-              await this.uploadIncompletePart(incompletePartId, fs.createReadStream(path))
+              await this.uploadIncompletePart(incompletePartId, readable)
             }
 
             bytesUploaded += partSize

Original file line number	Diff line number	Diff line change
`@@ -262,11 +262,13 @@ export class S3Store extends DataStore {`
`262`	`262`	`])`
`263`	`263`	`}`
`264`	`264`
	`265`	`+ const readable = fs.createReadStream(path)`
	`266`	`+ readable.on('error', reject)`
`265`	`267`	`if (partSize > this.minPartSize \|\| isFinalChunk) {`
`266`		`- await this.uploadPart(metadata, fs.createReadStream(path), partNumber)`
	`268`	`+ await this.uploadPart(metadata, readable, partNumber)`
`267`	`269`	`offset += partSize`
`268`	`270`	`} else {`
`269`		`- await this.uploadIncompletePart(incompletePartId, fs.createReadStream(path))`
	`271`	`+ await this.uploadIncompletePart(incompletePartId, readable)`
`270`	`272`	`}`
`271`	`273`
`272`	`274`	`bytesUploaded += partSize`