Upload-Defer-Length should only be set if Upload-Length is unknown

Author: Ben Stahl

lib/handlers/HeadHandler.js

@@ -35,9 +35,9 @@ class HeadHandler extends BaseHandler {
                     res.setHeader('Upload-Length', file.upload_length);
                 }
 
-                if ('upload_defer_length' in file) {
-                    // If the size of the upload is known, the Server MUST include
-                    // the Upload-Length header in the response.
+                if (!('upload_length' in file) && 'upload_defer_length' in file) {
+                    //  As long as the length of the upload is not known, the Server
+                    //  MUST set Upload-Defer-Length: 1 in all responses to HEAD requests.
                     res.setHeader('Upload-Defer-Length', file.upload_defer_length);
                 }
 

test/Test-FileStore.js

@@ -183,6 +183,18 @@ describe('FileStore', () => {
         });
 
         it('should return the defer header for deferred files', (done) => {
+            request(server.listen())
+            .head(`${STORE_PATH}/${deferred_file_path}`)
+            .set('Tus-Resumable', TUS_RESUMABLE)
+            .expect(200)
+            .end((err, res) => {
+                assert.equal(res.headers['upload-defer-length'], 1);
+                assert.equal(res.headers['upload-length'], undefined);
+                done();
+            });
+        });
+
+        it('should return the upload metatata', (done) => {
             request(server.listen())
             .head(`${STORE_PATH}/${created_file_path}`)
             .set('Tus-Resumable', TUS_RESUMABLE)