Skip to content

Commit 98760a9

Browse files
vencaxbhstahl
authored andcommitted
patch url generation fix
1 parent 3b3c61d commit 98760a9

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,9 @@ server.datastore = new tus.FileStore({
7575
});
7676

7777
var app = express();
78-
app.all('/files/*', function(req, res) {
79-
server.handle(req, res);
80-
});
78+
const uploadApp = express();
79+
uploadApp.all('*', server.handle.bind(server));
80+
app.use('/uploads', uploadApp);
8181
app.listen(port, host);
8282
```
8383

demo/server.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,18 @@ server.on(EVENTS.EVENT_UPLOAD_COMPLETE, (event) => {
6060
console.log(`[${new Date().toLocaleTimeString()}] [EVENT HOOK] Upload complete for file ${event.file.id}`);
6161
});
6262

63+
// // this is the express stile ;)
64+
// const express = require('express');
65+
// const app = express();
66+
// // Define routes to serve the demo html/js files.
67+
// app.get('/', writeFile);
68+
// app.get('/demo/index.js', writeFile);
69+
// app.get('/node_modules/tus-js-client/dist/tus.js', writeFile);
70+
//
71+
// const uploadApp = express();
72+
// uploadApp.all('*', server.handle.bind(server));
73+
// app.use('/uploads', uploadApp);
74+
6375
const host = '127.0.0.1';
6476
const port = 8000;
6577
server.listen({ host, port }, () => {

lib/handlers/BaseHandler.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class BaseHandler extends EventEmitter {
4141
* @return {bool|string}
4242
*/
4343
getFileIdFromRequest(req) {
44-
const re = new RegExp('\\' + this.store.path + '\\/(\\S+)\/?'); // eslint-disable-line prefer-template
44+
const re = new RegExp(`${req.baseUrl || this.store.path}\\/(\\S+)\\/?`); // eslint-disable-line prefer-template
4545
const match = (req.originalUrl || req.url).match(re);
4646
if (!match) {
4747
return false;

lib/handlers/PostHandler.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class PostHandler extends BaseHandler {
1515
send(req, res) {
1616
return this.store.create(req)
1717
.then((File) => {
18-
const url = `//${req.headers.host}${req.baseUrl || ''}${this.store.path}/${File.id}`;
18+
const url = `//${req.headers.host}${req.baseUrl || this.store.path}/${File.id}`;
1919
this.emit(EVENT_ENDPOINT_CREATED, { url });
2020
return super.send(res, 201, { Location: url });
2121
})

0 commit comments

Comments
 (0)