From b7b95916392f542109de13ee519dc1603449e42b Mon Sep 17 00:00:00 2001 From: Murderlon Date: Tue, 19 Aug 2025 14:40:30 +0200 Subject: [PATCH 1/2] @tus/s3-store: fix offset NaN when there are no parts --- packages/s3-store/src/index.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/s3-store/src/index.ts b/packages/s3-store/src/index.ts index 5009c602..e371f317 100644 --- a/packages/s3-store/src/index.ts +++ b/packages/s3-store/src/index.ts @@ -56,8 +56,7 @@ export type MetadataValue = { } function calcOffsetFromParts(parts?: Array) { - // @ts-expect-error not undefined - return parts && parts.length > 0 ? parts.reduce((a, b) => a + b.Size, 0) : 0 + return parts && parts.length > 0 ? parts.reduce((a, b) => a + (b.Size ?? 0), 0) : 0 } // Implementation (based on https://github.com/tus/tusd/blob/master/s3store/s3store.go) From 2cffb878577e9cd389391a4fcff3a828a8d851fa Mon Sep 17 00:00:00 2001 From: Merlijn Vos Date: Tue, 19 Aug 2025 14:41:25 +0200 Subject: [PATCH 2/2] Changeset --- .changeset/nasty-drinks-itch.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/nasty-drinks-itch.md diff --git a/.changeset/nasty-drinks-itch.md b/.changeset/nasty-drinks-itch.md new file mode 100644 index 00000000..450f373c --- /dev/null +++ b/.changeset/nasty-drinks-itch.md @@ -0,0 +1,5 @@ +--- +"@tus/s3-store": patch +--- + +Fix offset being returned as `NaN` when there are no S3 parts found