bug-fix_allow_partial_burn

tusharr1411 · tusharr1411 · commit c94e9218f6af · 2025-03-05T17:27:20.000+05:30
diff --git a/src/DSCEngine.sol b/src/DSCEngine.sol
@@ -182,10 +182,12 @@ contract DSCEngine is ReentrancyGuard {
         _revertIfHealthFactorIsBroken(msg.sender);
     }
 
-    //q I think here is an error of underflow
     function burnDSC(uint256 amount) public moreThanZero(amount) {
+        uint256 startingUserHealthFactor = _healthFactor(msg.sender);
         _burnDSC(msg.sender, msg.sender, amount);
-        _revertIfHealthFactorIsBroken(msg.sender);
+        uint256 endingUserHealthFactor = _healthFactor(msg.sender);
+        if (endingUserHealthFactor <= startingUserHealthFactor) revert DSCEngine__HealthFactorIsNotImproved(); // being extra safe
+            // _revertIfHealthFactorIsBroken(msg.sender); // this does not allow liquidatable account to partially burn some DSC
     }
 
     // $100 ETH backing $50 DSC

Original file line number	Diff line number	Diff line change
`@@ -182,10 +182,12 @@ contract DSCEngine is ReentrancyGuard {`
`182`	`182`	`_revertIfHealthFactorIsBroken(msg.sender);`
`183`	`183`	`}`
`184`	`184`
`185`		`- //q I think here is an error of underflow`
`186`	`185`	`function burnDSC(uint256 amount) public moreThanZero(amount) {`
	`186`	`+ uint256 startingUserHealthFactor = _healthFactor(msg.sender);`
`187`	`187`	`_burnDSC(msg.sender, msg.sender, amount);`
`188`		`- _revertIfHealthFactorIsBroken(msg.sender);`
	`188`	`+ uint256 endingUserHealthFactor = _healthFactor(msg.sender);`
	`189`	`+ if (endingUserHealthFactor <= startingUserHealthFactor) revert DSCEngine__HealthFactorIsNotImproved(); // being extra safe`
	`190`	`+ // _revertIfHealthFactorIsBroken(msg.sender); // this does not allow liquidatable account to partially burn some DSC`
`189`	`191`	`}`
`190`	`192`
`191`	`193`	`// $100 ETH backing $50 DSC`