Skip to content

Use QRCode generator without minified source #2505

@jowlo

Description

@jowlo

We are using qrcode-svg to generate QRCodes for our gift cards and for registering new TOTPs. qrcode-svg uses a lot of minified code 🤦‍♂️ that we also copied over.

The minified code is actually from qrcode-generator which is also on npm and provides SVG support natively (nowadays). As a bonus, it is not minified. For the qr codes on gift cards we need color support. I made a PR upstream.

A version containing the libs/qrcode.js after the PR is accepted is on qrcode-no-minified.

Metadata

Metadata

Assignees

Labels

maintenancedependency updates, key renewals, code cleanup

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions