-
Notifications
You must be signed in to change notification settings - Fork 600
Description
- This is not a feature request (existing functionality does not work, not missing functionality).
I will request features on forum or via support. - I've searched and did not find a similar issue.
Describe the bug
In the calendar event editor, when the "All Day" toggle is enabled, the time input fields (From/To) still display "00:00" times instead of
being hidden. This is confusing and clutters the UI since time is irrelevant for all-day events.
To Reproduce
Steps to reproduce the behavior:
- Go to Calendar app
- Create or edit an event
- Enable "All Day" toggle
- See From/To time fields still showing "00:00"
Expected behavior
When "All Day" toggle is enabled, the time input fields should be hidden completely, showing only the date fields.
Desktop (please complete the following information):
- OS: All platforms (iOS, Android, Web, Desktop)
- Desktop Environment, if applicable (on Linux): N/A
- Version: Current master
Additional context
Root cause:
src/calendar-app/calendar/gui/eventeditor-view/EventTimeEditor.ts lines 80-87 and 109-116 - the TimePicker components are disabled when isAllDay is true but still rendered, showing "00:00" times.
Proposed fix:
Hide TimePicker components entirely when isAllDay is true by conditionally rendering them only when
!attrs.editModel.isAllDay.
I have a working fix ready to submit.