Merge pull request #1077 from lgriffin/fix/runtime-bugs-and-types

Fix memory leaks, invalid HTML, and improve type safety

Author: edeleastar

src/lib/ui/learning-objects/content/Podcast.svelte

@@ -4,6 +4,7 @@
 
   interface Props {
     lo: Podcast;
+    hideSummary?: boolean;
   }
   let { lo, hideSummary = false }: Props = $props();
 

src/lib/ui/learning-objects/layout/Cards.svelte

@@ -1,10 +1,9 @@
 <script lang="ts">
-  import { onMount } from "svelte";
+  import { onMount, onDestroy } from "svelte";
 
   import type { Lo } from "@tutors/tutors-model-lib";
 
   import Card from "$lib/ui/learning-objects/layout/Card.svelte";
-  import { cubicOut } from "svelte/easing";
   import { scale } from "svelte/transition";
   import { scaleTransition } from "$lib/ui/navigators/animations";
   import { currentCourse } from "$lib/runes.svelte";
@@ -19,8 +18,9 @@
   let ignorePin = "";
   let refresh = $state(true);
   let isLoaded = $state(false);
+  let hasKeyListener = false;
 
-  function keypressInput(e: { key: string }) {
+  function keypressInput(e: KeyboardEvent) {
     pinBuffer = pinBuffer.concat(e.key);
     if (pinBuffer === ignorePin) {
       los.forEach((lo) => {
@@ -35,9 +35,16 @@
     if (currentCourse?.value?.properties.ignorepin) {
       ignorePin = currentCourse?.value?.properties.ignorepin.toString();
       window.addEventListener("keydown", keypressInput);
+      hasKeyListener = true;
     }
     isLoaded = true;
   });
+
+  onDestroy(() => {
+    if (hasKeyListener) {
+      window.removeEventListener("keydown", keypressInput);
+    }
+  });
 </script>
 
 {#if los.length > 0 && isLoaded}

src/lib/ui/navigators/buttons/SearchButton.svelte

@@ -1,12 +1,13 @@
 <script lang="ts">
   import { goto } from "$app/navigation";
-  import { onDestroy } from "svelte";
+  import { onMount, onDestroy } from "svelte";
   import { currentCourse } from "$lib/runes.svelte";
   import Icon from "$lib/ui/components/Icon.svelte";
   import { t } from "$lib/services/i18n";
 
-  let isSearching = sessionStorage.getItem("isSearching") === "true";
+  let isSearching = $state(sessionStorage.getItem("isSearching") === "true");
   let previousPage = "";
+  let observer: MutationObserver | null = null;
 
   const updateSearchState = () => {
     const currentPath = window.location.pathname;
@@ -37,17 +38,18 @@
     }
   };
 
-  const observer = new MutationObserver(checkForNavigation);
-  observer.observe(document.body, {
-    childList: true,
-    subtree: true
+  onMount(() => {
+    observer = new MutationObserver(checkForNavigation);
+    observer.observe(document.body, {
+      childList: true,
+      subtree: true
+    });
+    window.addEventListener("popstate", updateSearchState);
+    updateSearchState();
   });
 
-  window.addEventListener("popstate", updateSearchState);
-  updateSearchState();
-
   onDestroy(() => {
-    observer.disconnect();
+    observer?.disconnect();
     window.removeEventListener("popstate", updateSearchState);
   });
 </script>

src/routes/(auth)/auth/[courseid]/+page.svelte

@@ -1,8 +1,9 @@
 <script lang="ts">
   import SigninWithGithub from "../SigninWithGithub.svelte";
+  import type { PageData } from "./$types";
 
   interface Props {
-    data: any;
+    data: PageData;
   }
   let { data }: Props = $props();
 </script>

src/routes/(course-reader)/course/[courseid]/+page.svelte

@@ -1,8 +1,9 @@
 <script lang="ts">
   import Composite from "$lib/ui/learning-objects/structure/Composite.svelte";
+  import type { PageData } from "./$types";
 
   interface Props {
-    data: any;
+    data: PageData;
   }
   let { data }: Props = $props();
 </script>

src/routes/(course-reader)/llm/[courseid]/+page.svelte

@@ -3,10 +3,11 @@
   import { currentCourse } from "$lib/runes.svelte";
   import { convertMdToHtml } from "@tutors/tutors-model-lib";
   import SecondaryNavigator from "$lib/ui/navigators/SecondaryNavigator.svelte";
+  import type { PageData } from "./$types";
   import { sanitizeHtml } from "$lib/utils/sanitize";
 
   interface Props {
-    data: any;
+    data: PageData;
   }
   let { data }: Props = $props();
 

src/routes/(course-reader)/time/[courseid]/+page.svelte

@@ -4,10 +4,11 @@
   import HeatMaps from "./HeatMaps.svelte";
   import Tables from "./Tables.svelte";
   import SecondaryNavigator from "$lib/ui/navigators/SecondaryNavigator.svelte";
+  import type { PageData } from "./$types";
   import log from "$lib/services/logger";
 
   interface Props {
-    data: any;
+    data: PageData;
   }
   let { data }: Props = $props();
 

src/routes/(live)/catalogue/+page.svelte

@@ -2,9 +2,10 @@
   import { catalogueService } from "$lib/services/community";
   import Catalogue from "$lib/ui/time/Catalogue.svelte";
   import { onMount } from "svelte";
+  import type { PageData } from "./$types";
 
   interface Props {
-    data: any;
+    data: PageData;
   }
   let { data }: Props = $props();
   let totalModules = $state(0);