Commit ba6baec
committed
fix(security): address review findings in build_run and monitor_helper
- build_run.py: subtract 1s tolerance from build_start before comparing
mtime to prevent false-positive rejection on filesystems with 1-second
mtime granularity when the build completes in under one second
- monitor_helper.py: use wmic to verify process CommandLine on Windows
instead of unconditionally returning True; use os.path.realpath on both
sides of the log-path confinement check to block symlink-based escapes1 parent 85ec6fd commit ba6baec
2 files changed
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | | - | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
122 | 127 | | |
123 | 128 | | |
124 | 129 | | |
| |||
154 | 159 | | |
155 | 160 | | |
156 | 161 | | |
157 | | - | |
158 | | - | |
| 162 | + | |
| 163 | + | |
159 | 164 | | |
160 | 165 | | |
161 | 166 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
0 commit comments