Fix example data creation

Author: tuzumkuru

lib/tasks/create_test_data.rake

@@ -1,108 +1,70 @@
 namespace :redmine do
-  desc "Create a test project and a test issue"
+  desc "Create a test project and a test issue with a detailed history"
   task create_test_data: :environment do
-    # Check if a project with the identifier already exists
-    project_identifier = "test-project"
-    existing_project = Project.find_by(identifier: project_identifier)
-    if existing_project
-      puts "Project with identifier '#{project_identifier}' already exists. Skipping creation."
-      project = existing_project
-    else
-      # Create the test project
-      project = Project.new(
-        name: "Test Project",
-        identifier: project_identifier,
-        description: "This is a test project."
-      )
-      if project.save
-        puts "Test project created with ID: #{project.id}"
-      else
-        puts "Failed to create test project: #{project.errors.full_messages.join(', ')}"
-        exit 1
-      end
+    # --- 1. SETUP PROJECT AND AUTHOR ---
+    project = Project.find_or_create_by!(identifier: "test-project") do |p|
+      p.name = "Test Project"
+      p.description = "This is a test project."
+      puts "Test project created."
     end
 
-    # Fetch the first user as the author (assuming default data is loaded)
     author = User.active.first
     unless author
-      puts "No active user found to set as the author of the issue. Please ensure users exist."
-      exit 1
+      puts "No active user found. Please ensure users exist."
+      return
     end
 
-    # Create a test issue if it doesn't already exist
+    # --- 2. CREATE THE ISSUE (if it doesn't exist) ---
     issue_subject = "Signup confirmation emails not sent"
-    existing_issue = Issue.find_by(subject: issue_subject, project_id: project.id)
-    if existing_issue
-      puts "Issue with subject '#{issue_subject}' already exists in the project. Skipping creation."
-    else
-      issue = Issue.new(
-        project_id: project.id,
-        tracker: Tracker.first, # Assuming you have at least one tracker
-        subject: issue_subject,
-        description: "Users are not receiving signup confirmation emails in production.\nObserved: multiple users report they never receive the confirmation email after registering.\nExpected: users should receive a confirmation email that contains an activation link.",
-        author_id: author.id
-      )
-
-      if issue.save
-        puts "Test issue created with ID: #{issue.id}"
-
-        # reload to obtain the latest lock_version before further updates
-        issue.reload
-
-        # 1) Add an initial note with reproduction steps and observations
-        issue.init_journal(author, "Initial analysis: no emails found in the mailer logs for recent signups. Repro steps: 1) Go to /signup 2) Create a new account 3) Observe no confirmation email received.")
-        if issue.save
-          puts "Added initial note to issue ##{issue.id}."
-        else
-          puts "Failed to add initial note: #{issue.errors.full_messages.join(', ')}"
-        end
+    issue = Issue.find_or_initialize_by(subject: issue_subject, project_id: project.id)
 
-        issue.reload
-
-        # 2) Assign to a developer and raise priority with a note describing next actions
-        assignee = User.active.where.not(id: author.id).first || author
-        high_priority = IssuePriority.order(:id).last || IssuePriority.first
-        issue.init_journal(author, "Assigning to #{assignee.login} to investigate SMTP and mailer settings. Will check environment variables and mailer host.")
-        issue.assigned_to = assignee
-        issue.priority = high_priority
-        if issue.save
-          puts "Assigned issue ##{issue.id} to #{assignee.login} and set priority to '#{high_priority.name}'."
-        else
-          puts "Failed to assign or set priority: #{issue.errors.full_messages.join(', ')}"
-        end
-
-        issue.reload
+    if issue.new_record?
+      issue.assign_attributes(
+        tracker: Tracker.first,
+        description: "Users are not receiving signup confirmation emails in production...",
+        author: author
+      )
+      issue.save!
+      puts "Test issue created with ID: #{issue.id}"
 
-        # 3) Change status to 'In Progress' without a note (simulating a status-only update)
-        in_progress = IssueStatus.find_by(name: 'In Progress') || IssueStatus.find_by(is_default: false) || IssueStatus.first
-        issue.init_journal(author)
-        issue.status = in_progress
-        # Ensure no notes are saved for this transition
-        issue.notes = nil
-        if issue.save
-          puts "Changed status of issue ##{issue.id} to '#{in_progress.name}' without a note."
-        else
-          puts "Failed to change status: #{issue.errors.full_messages.join(', ')}"
-        end
+      # --- 3. ADD SEPARATE UPDATES TO THE ISSUE HISTORY ---
+      # Each block now starts by re-finding the issue to guarantee a fresh object.
 
-        issue.reload
+      # Update 1: Add initial analysis note
+      issue = Issue.find(issue.id) # Re-find the issue
+      issue.init_journal(author, "Initial analysis: no emails found in the mailer logs for recent signups. Repro steps: 1) Go to /signup 2) Create a new account 3) Observe no confirmation email received.")
+      issue.save!
+      puts "Added initial note to issue ##{issue.id}."
 
-        # 4) Developer adds a follow-up note with findings (e.g. missing MAILER_HOST) and marks for fix
-        issue.init_journal(assignee, "Follow-up: found MAILER_HOST environment variable missing in production. Will add default and redeploy to staging for verification.")
-        issue.status = in_progress
-        if issue.save
-          puts "Added developer follow-up note to issue ##{issue.id}."
-        else
-          puts "Failed to add developer note: #{issue.errors.full_messages.join(', ')}"
-        end
+      # Update 2: Assign, raise priority, and add a note
+      issue = Issue.find(issue.id) # Re-find the issue
+      assignee = User.active.where.not(id: author.id).first || author
+      high_priority = IssuePriority.order(:position).last
+      issue.init_journal(author, "Assigning to #{assignee.login} to investigate SMTP and mailer settings.")
+      issue.assigned_to = assignee
+      issue.priority = high_priority
+      issue.save!
+      puts "Assigned issue ##{issue.id} to #{assignee.login} and set priority."
 
-      else
-        puts "Failed to create test issue: #{issue.errors.full_messages.join(', ')}"
-        exit 1
+      # Update 3: Change status to 'In Progress' without a note
+      issue = Issue.find(issue.id) # Re-find the issue
+      in_progress_status = IssueStatus.find_by(name: 'In Progress')
+      if in_progress_status
+        issue.init_journal(assignee) # Journal entry is created by the new assignee
+        issue.status = in_progress_status
+        issue.save!
+        puts "Changed status of issue ##{issue.id} to '#{in_progress_status.name}'."
       end
+
+      # Update 4: Developer adds a follow-up note
+      issue = Issue.find(issue.id) # Re-find the issue
+      issue.init_journal(assignee, "Follow-up: found MAILER_HOST environment variable missing in production. Will add default and redeploy.")
+      issue.save!
+      puts "Added developer follow-up note to issue ##{issue.id}."
+      
+      puts "Successfully created issue ##{issue.id} with multiple history entries."
+    else
+      puts "Issue with subject '#{issue_subject}' already exists. Skipping."
     end
   end
-end
-
-
-
+end