Skip to content

Fix drawer-sheet not respecting start/end placement - #42755

Open
wasinger wants to merge 1 commit into
twbs:v6-devfrom
wasinger:v6-right-drawer-fix
Open

Fix drawer-sheet not respecting start/end placement#42755
wasinger wants to merge 1 commit into
twbs:v6-devfrom
wasinger:v6-right-drawer-fix

Conversation

@wasinger

Copy link
Copy Markdown

Description

Make .drawer-sheet respect .drawer-start and .drawer-end. Fixes #42754.

Motivation & Context

In the current state of v6-dev, the Sheet drawer works only when aligned to bottom. Aligning to left or right does not work, the drawer is always centered horizontally.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • No live preview available because netlify somehow doesn't work for me...

Related issues

#42754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

3 participants