Skip to content

Commit 36b7c52

Browse files
committed
sh_posix_toolchain prototype change: update CHANGELOG.md accordingly
1 parent 59d5763 commit 36b7c52

File tree

1 file changed

+24
-0
lines changed

1 file changed

+24
-0
lines changed

CHANGELOG.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,30 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/).
88

99
[Unreleased]: https://github.com/tweag/rules_sh/compare/v0.1.1...HEAD
1010

11+
### Changed
12+
13+
- `sh_posix_toolchain` now has a single attribute `cmds`, which
14+
is a string to string `dict`; instead of having one attribute
15+
per member of `posix.commands`. It is a breaking change if you were
16+
calling `sh_posix_toolchain` directly.
17+
18+
If you were calling this rule as follows:
19+
20+
```
21+
sh_posix_toolchain(cat = "/bin/cat", wc = "/usr/bin/wc")
22+
```
23+
24+
you should now do:
25+
26+
```
27+
sh_posix_toolchain(cmds = { "cat": "/bin/cat", "wc": "/usr/bin/wc" })
28+
```
29+
30+
See PR [#14][#14] and issue [#13][#13] for the motivation.
31+
32+
[#14]: https://github.com/tweag/rules_sh/pull/14
33+
[#13]: https://github.com/tweag/rules_sh/issues/13
34+
1135
## [0.1.1] - 2019-11-13
1236

1337
[0.1.1]: https://github.com/tweag/rules_sh/compare/v0.1.0...v0.1.1

0 commit comments

Comments
 (0)