fix: Vite 8/Rolldown build warnings in library packages#22205
fix: Vite 8/Rolldown build warnings in library packages#22205parshipcy wants to merge 2 commits into
Conversation
Signed-off-by: Parship Chowdhury <parshipchowdhury@gmail.com>
|
👋 Thanks for contributing to Twenty! Your PR has been set to draft while you work on it. Once you're done, mark it as Ready for review and our automated checks will run. Looking forward to your contribution! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🔍 Visual Regression Review —
|
| // @ts-expect-error: no type declarations for path in this config | ||
| import path from 'path'; | ||
| import { defineConfig } from 'vite'; | ||
| // @ts-expect-error: importing JSON without resolveJsonModule |
🔍 Automated Pre-Review✅ No issues detected - This PR is ready for human review. 🧭 External PR Quality Review🟠 Needs triage for the following reason(s):
cc @prastoin Checks
Detailed findings (duplicate candidates, standards notes, summary) are in the workflow run logs. Automated pre-review — human approval still required. |
🔍 Visual Regression Review —
|
| Story | Verdict | Confidence | Explained by | |
|---|---|---|---|---|
| 🟡 | modules-settings-accounts-blocklist-settingsaccountsblocklistinput--default |
uncertain | 75% | No UI files changed — PR only modifies Vite build config files (twenty-ui/vite.c… |
| 🟡 | modules-settings-accounts-blocklist-settingsaccountsblocklistsection--default |
uncertain | 75% | No UI files changed — PR only modifies Vite build config files and a path utilit… |
| 🟡 | modules-auth-signinupworkspaceactivationv2--default |
uncertain | 80% | No UI files changed — PR only modifies Vite build config files and a path utilit… |
Changed stories
| Story | Diff % |
|---|---|
| modules-settings-accounts-blocklist-settingsaccountsblocklistinput--default | 1% |
| modules-settings-accounts-blocklist-settingsaccountsblocklistsection--default | 1% |
| modules-auth-signinupworkspaceactivationv2--default | 1% |
View run details · advisory mode
1 participant
Clean up Vite 8/Rolldown build warnings that showed up during yarn start:
twenty-client-sdk:relativeImportPath.tsnow importsnode:path, so the generate bundle treats it as a Node external instead of stubbing it for the browser.interop: 'auto'from CJS output options - Rolldown don’t support it and was showingInvalid key: Expected never but received "interop".inlineDynamicImports: truewithcodeSplitting: falsein the worker config.References: