Skip to content

Commit 0c1ffd8

Browse files
IObertclaude
andcommitted
ci: forward deploy-specific credential overrides in Deploy workflow
DEPLOY_ADMIN_LOGIN/DEPLOY_MIXOLOGIST_LOGIN/DEPLOY_KIOSK_LOGIN weren't wired into the generated .env.local, so an automated deploy would have silently reset the live app's admin/mixologist/kiosk credentials back to the local-dev defaults. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent a62a2dc commit 0c1ffd8

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,12 @@ jobs:
4848
ADMIN_LOGIN: ${{ vars.ADMIN_LOGIN }}
4949
MIXOLOGIST_LOGIN: ${{ vars.MIXOLOGIST_LOGIN }}
5050
KIOSK_LOGIN: ${{ vars.KIOSK_LOGIN }}
51+
# Deploy-specific overrides — deploy.sh sets these as the live app's
52+
# credentials instead of ADMIN_LOGIN/MIXOLOGIST_LOGIN/KIOSK_LOGIN
53+
# above (which are the local-dev credentials) when present.
54+
DEPLOY_ADMIN_LOGIN: ${{ secrets.DEPLOY_ADMIN_LOGIN }}
55+
DEPLOY_MIXOLOGIST_LOGIN: ${{ secrets.DEPLOY_MIXOLOGIST_LOGIN }}
56+
DEPLOY_KIOSK_LOGIN: ${{ secrets.DEPLOY_KIOSK_LOGIN }}
5157
SERVICE_INSTANCE_PREFIX: ${{ vars.SERVICE_INSTANCE_PREFIX }}
5258
UNLIMITED_ORDERS: ${{ vars.UNLIMITED_ORDERS }}
5359
run: |
@@ -73,6 +79,9 @@ jobs:
7379
ADMIN_LOGIN=$ADMIN_LOGIN
7480
MIXOLOGIST_LOGIN=$MIXOLOGIST_LOGIN
7581
KIOSK_LOGIN=$KIOSK_LOGIN
82+
DEPLOY_ADMIN_LOGIN=$DEPLOY_ADMIN_LOGIN
83+
DEPLOY_MIXOLOGIST_LOGIN=$DEPLOY_MIXOLOGIST_LOGIN
84+
DEPLOY_KIOSK_LOGIN=$DEPLOY_KIOSK_LOGIN
7685
SERVICE_INSTANCE_PREFIX=$SERVICE_INSTANCE_PREFIX
7786
UNLIMITED_ORDERS=$UNLIMITED_ORDERS
7887
EOF

0 commit comments

Comments
 (0)