Fix date time iso8601 serializer

Author: codejudas

CHANGES.md

@@ -3,17 +3,19 @@ twilio-csharp Changelog
 
 [2017-06-30] Version 5.5.2
 ---------------------------
+- Fix Url parameters with percent encoded characters not being properly serialized before being sent to the API.
+- Fix Iso8601 date time serialization not enforcing expected culture, timezone. Issue #372.
+- Support Recording encryption. Add `EncryptionType` and `EncryptionDetails` parameters to call recordings.
+- Add new usage record categories for rooms and speech recognition.
 
 **Video**
-
 - Filter recordings by date using the parameters `DateCreatedAfter` and `DateCreatedBefore`.
 - Override the default time-to-live of a recording's media URL through the `Ttl` parameter (in seconds, default value is 3600).
 - Add query parameters `SourceSid`, `Status`, `DateCreatedAfter` and `DateCreatedBefore` to the convenience method for retrieving Room recordings.
-**Wireless**
 
+**Wireless**
 - Added national and international data limits to the RatePlans resource.
 
-
 [2017-06-16] Version 5.5.1
 --------------------------
 - Make url parameter optional in Play Twiml.

src/Twilio/Converters/Serializers.cs

@@ -25,25 +25,11 @@ public static string JsonObject(object input)
         /// </summary>
         /// <param name="input">DateTime instance to serialize to string</param>
         /// <returns>A string</returns>
-        public static string DateTimeIso8601(DateTime input)
-        {
-              return input.ToString("yyyy-MM-ddTHH:mm:ssZ");
-        }
-
-        /// <summary>
-        /// Produce a ISO 8601 UTC compatible string from input if possible
-        /// </summary>
-        /// <param name="input">string representation of a time which will be converted to an iso8601 UTC string</param>
-        /// <returns>A string</returns>
-        public static string DateTimeIso8601(string input)
+        public static string DateTimeIso8601(DateTime? input)
         {
             if (input == null) return null;
 
-            var enUS = new CultureInfo("en-US");
-            var utc = DateTimeStyles.AdjustToUniversal;
-            DateTime parsedDateTime;
-
-            return DateTime.TryParse(input, enUS, utc, out parsedDateTime) ? DateTimeIso8601(parsedDateTime) : input;
+            return input.Value.ToString("yyyy-MM-ddTHH:mm:ssZ");
         }
     }
 }

test/Twilio.Test/Converters/SerializersTest.cs

@@ -52,34 +52,11 @@ public void TestDateTimeIso8601WithDateTime()
             Assert.AreEqual(expect, result);
         }
 
-        [Test]
-        public void TestDateTimeIso8601WithString()
-        {
-            var input = "2017-06-19T12:13:14Z";
-            var result = Serializers.DateTimeIso8601(input);
-            Assert.AreEqual(input, result);
-        }
-
-        [Test]
-        public void TestDateTimeIso8601WithStringConvertsTZ()
-        {
-            var result = Serializers.DateTimeIso8601("2017-06-19T11:13:14-01:00");
-            Assert.AreEqual("2017-06-19T12:13:14Z", result);
-        }
-
         [Test]
         public void TestDateTimeIso8601WithNull()
         {
             var result = Serializers.DateTimeIso8601(null);
             Assert.AreEqual(null, result);
         }
-
-        [Test]
-        public void TestDateTimeIso8601WithGarbage()
-        {
-            var result = Serializers.DateTimeIso8601("not-a-time");
-            Assert.AreEqual("not-a-time", result);
-        }
-
     }
 }