-
Notifications
You must be signed in to change notification settings - Fork 471
Open
Labels
status: help wantedrequesting help from the communityrequesting help from the communitytype: bugbug in the librarybug in the library
Description
Issue Summary
Same issue as #406
I see from v1 https://github.com/twilio/twilio-ruby/blob/6.0.2/lib/twilio-ruby/rest/lookups/v1/phone_number.rb#L53 to v2 the escaping was removed.
- @uri = "/PhoneNumbers/#{CGI.escape(@solution[:phone_number]).gsub("+", "%20")}"
+ @uri = "/PhoneNumbers/#{@solution[:phone_number]}"Proposal
use URI::DEFAULT_PARSER.escape just like Rails does
@uri = "/PhoneNumbers/#{URI::DEFAULT_PARSER.escape(@solution[:phone_number])}"
Steps to Reproduce
- look up a phone number with a space in it
see #406
Code Snippet
see #406
Exception/Log
see #406
Technical details:
- twilio-ruby version: 6.0.1
- ruby version: 3.1
rafaeelaudibert, davefp, yurimdh and jaysonvirissimo
Metadata
Metadata
Assignees
Labels
status: help wantedrequesting help from the communityrequesting help from the communitytype: bugbug in the librarybug in the library