2323#import < TwitterLoggingService/TLSDeclarations.h>
2424#import < TwitterLoggingService/TLSLog.h>
2525
26- NSString * const TLSErrorDomain = @" TLSErrorDomain" ;
26+ NSErrorDomain const TLSErrorDomain = @" TLSErrorDomain" ;
2727
2828@implementation TLSLogMessageInfo
2929{
@@ -87,7 +87,7 @@ - (NSString *)composeFormattedMessageWithOptions:(TLSComposeLogMessageInfoOption
8787 // TIMESTAMP
8888 {
8989 NSString *logTimestamp = nil ;
90- if (options & TLSComposeLogMessageInfoLogTimestampAsTimeSinceLoggingStarted) {
90+ if (TLS_BITMASK_INTERSECTS_FLAGS ( options, TLSComposeLogMessageInfoLogTimestampAsTimeSinceLoggingStarted) ) {
9191 NSTimeInterval logLifespan = self.logLifespan ;
9292 const BOOL negative = logLifespan < 0.0 ;
9393 if (negative) {
@@ -108,7 +108,7 @@ - (NSString *)composeFormattedMessageWithOptions:(TLSComposeLogMessageInfoOption
108108 minutes,
109109 seconds,
110110 msecs];
111- } else if (options & TLSComposeLogMessageInfoLogTimestampAsLocalTime) {
111+ } else if (TLS_BITMASK_INTERSECTS_FLAGS ( options, TLSComposeLogMessageInfoLogTimestampAsLocalTime) ) {
112112 static NSDateFormatter *sFormatter = nil ;
113113 static dispatch_once_t onceToken;
114114 dispatch_once (&onceToken, ^{
@@ -117,7 +117,7 @@ - (NSString *)composeFormattedMessageWithOptions:(TLSComposeLogMessageInfoOption
117117 sFormatter .timeZone = [NSTimeZone localTimeZone ];
118118 });
119119 logTimestamp = [sFormatter stringFromDate: self .timestamp];
120- } else if (options & TLSComposeLogMessageInfoLogTimestampAsUTCTime) {
120+ } else if (TLS_BITMASK_INTERSECTS_FLAGS ( options, TLSComposeLogMessageInfoLogTimestampAsUTCTime) ) {
121121 static NSDateFormatter *sFormatter = nil ;
122122 static dispatch_once_t onceToken;
123123 dispatch_once (&onceToken, ^{
@@ -134,38 +134,39 @@ - (NSString *)composeFormattedMessageWithOptions:(TLSComposeLogMessageInfoOption
134134 }
135135
136136 // THREAD
137- if (options & TLSComposeLogMessageInfoLogThreadId || options & TLSComposeLogMessageInfoLogThreadName) {
137+ if (TLS_BITMASK_INTERSECTS_FLAGS ( options, TLSComposeLogMessageInfoLogThreadId | TLSComposeLogMessageInfoLogThreadName) ) {
138138 [mComposedMessage appendString: @" [" ];
139139 NSString *threadName = self.threadName ;
140- const BOOL hasName = (options & TLSComposeLogMessageInfoLogThreadName && threadName != nil );
140+ const BOOL hasName = TLS_BITMASK_INTERSECTS_FLAGS (options, TLSComposeLogMessageInfoLogThreadName)
141+ && (threadName != nil );
141142 if (hasName) {
142143 [mComposedMessage appendString: threadName];
143144 }
144- if (options & TLSComposeLogMessageInfoLogThreadId) {
145+ if (TLS_BITMASK_INTERSECTS_FLAGS ( options, TLSComposeLogMessageInfoLogThreadId) ) {
145146 [mComposedMessage appendFormat: (hasName) ? @" (0x%x )" : @" 0x%x " , self .threadId];
146147 }
147148 [mComposedMessage appendString: @" ]" ];
148149 }
149150
150151 // CHANNEL
151- if (options & TLSComposeLogMessageInfoLogChannel) {
152+ if (TLS_BITMASK_INTERSECTS_FLAGS ( options, TLSComposeLogMessageInfoLogChannel) ) {
152153 [mComposedMessage appendFormat: @" [%@ ]" , self .channel];
153154 }
154155
155156 // LEVEL
156- if (options & TLSComposeLogMessageInfoLogLevel) {
157+ if (TLS_BITMASK_INTERSECTS_FLAGS ( options, TLSComposeLogMessageInfoLogLevel) ) {
157158 [mComposedMessage appendFormat: @" [%@ ]" , TLSLogLevelToString (level)];
158159 }
159160
160161 // Call Site Info
161- if ((options & TLSComposeLogMessageInfoLogCallsiteInfoAlways) || ((options & TLSComposeLogMessageInfoLogCallsiteInfoForWarnings) && level <= TLSLogLevelWarning) ) {
162+ if (TLS_BITMASK_INTERSECTS_FLAGS (options, TLSComposeLogMessageInfoLogCallsiteInfoAlways | TLSComposeLogMessageInfoLogCallsiteInfoForWarnings) && level <= TLSLogLevelWarning) {
162163 [mComposedMessage appendString: [self composeFileFunctionLineString ]];
163164 }
164165
165166 [mComposedMessage appendFormat: @" : %@ " , self .message];
166167
167168 composedMessage = [mComposedMessage copy ];
168- if (0 == (options & TLSComposeLogMessageInfoDoNotCache)) {
169+ if (TLS_BITMASK_EXCLUDES_FLAGS (options, TLSComposeLogMessageInfoDoNotCache)) {
169170 if (!_formattedMessages) {
170171 _formattedMessages = @{ optionsKey : composedMessage };
171172 } else {
0 commit comments