Skip to content

Consistent nbt.TAG* init parameters #46

Open
@macfreek

Description

@macfreek

A small annoyance (to me). The parameters of the __init__ functions in nbt.TAG classes are very inconsistent. May I fix this?

Are there preferences for proposal 1 or proposal 2?

Current __init__ methods

class TAG(object):
    def __init__(self, value=None, name=None):
class _TAG_Numeric(TAG):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_Byte_Array(TAG, MutableSequence):
    def __init__(self, name=None, buffer=None):
class TAG_Int_Array(TAG, MutableSequence):
    def __init__(self, name=None, buffer=None):
class TAG_String(TAG, Sequence):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_List(TAG, MutableSequence):
    def __init__(self, type=None, value=None, name=None, buffer=None):
class TAG_Compound(TAG, MutableMapping):
    def __init__(self, buffer=None):

Proposal 1

class TAG(object):
    def __init__(self, value=None, name=None, buffer=None):
class _TAG_Numeric(TAG):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_Byte_Array(TAG, MutableSequence):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_Int_Array(TAG, MutableSequence):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_String(TAG, Sequence):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_List(TAG, MutableSequence):
    def __init__(self, type=None, value=None, name=None, buffer=None):
class TAG_Compound(TAG, MutableMapping):
    def __init__(self, value=None, name=None, buffer=None):

Proposal 2

class TAG(object):
    def __init__(self, name=None, value=None, buffer=None):
class _TAG_Numeric(TAG):
    def __init__(self, name=None, value=None, buffer=None):
class TAG_Byte_Array(TAG, MutableSequence):
    def __init__(self, name=None, value=None, buffer=None):
class TAG_Int_Array(TAG, MutableSequence):
    def __init__(self, name=None, value=None, buffer=None):
class TAG_String(TAG, Sequence):
    def __init__(self, name=None, value=None, buffer=None):
class TAG_List(TAG, MutableSequence):
    def __init__(self, name=None, type=None, value=None, buffer=None):
class TAG_Compound(TAG, MutableMapping):
    def __init__(self, name=None, value=None, buffer=None):

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions