Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent nbt.TAG* init parameters #46

Open
macfreek opened this issue Apr 12, 2012 · 0 comments
Open

Consistent nbt.TAG* init parameters #46

macfreek opened this issue Apr 12, 2012 · 0 comments

Comments

@macfreek
Copy link
Collaborator

A small annoyance (to me). The parameters of the __init__ functions in nbt.TAG classes are very inconsistent. May I fix this?

Are there preferences for proposal 1 or proposal 2?

Current __init__ methods

class TAG(object):
    def __init__(self, value=None, name=None):
class _TAG_Numeric(TAG):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_Byte_Array(TAG, MutableSequence):
    def __init__(self, name=None, buffer=None):
class TAG_Int_Array(TAG, MutableSequence):
    def __init__(self, name=None, buffer=None):
class TAG_String(TAG, Sequence):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_List(TAG, MutableSequence):
    def __init__(self, type=None, value=None, name=None, buffer=None):
class TAG_Compound(TAG, MutableMapping):
    def __init__(self, buffer=None):

Proposal 1

class TAG(object):
    def __init__(self, value=None, name=None, buffer=None):
class _TAG_Numeric(TAG):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_Byte_Array(TAG, MutableSequence):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_Int_Array(TAG, MutableSequence):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_String(TAG, Sequence):
    def __init__(self, value=None, name=None, buffer=None):
class TAG_List(TAG, MutableSequence):
    def __init__(self, type=None, value=None, name=None, buffer=None):
class TAG_Compound(TAG, MutableMapping):
    def __init__(self, value=None, name=None, buffer=None):

Proposal 2

class TAG(object):
    def __init__(self, name=None, value=None, buffer=None):
class _TAG_Numeric(TAG):
    def __init__(self, name=None, value=None, buffer=None):
class TAG_Byte_Array(TAG, MutableSequence):
    def __init__(self, name=None, value=None, buffer=None):
class TAG_Int_Array(TAG, MutableSequence):
    def __init__(self, name=None, value=None, buffer=None):
class TAG_String(TAG, Sequence):
    def __init__(self, name=None, value=None, buffer=None):
class TAG_List(TAG, MutableSequence):
    def __init__(self, name=None, type=None, value=None, buffer=None):
class TAG_Compound(TAG, MutableMapping):
    def __init__(self, name=None, value=None, buffer=None):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant