Skip to content

Commit 455763b

Browse files
committed
8328819: Remove applet usage from JFileChooser tests bug6698013
Backport-of: e3588bb
1 parent f9d2fb8 commit 455763b

File tree

2 files changed

+38
-57
lines changed

2 files changed

+38
-57
lines changed

test/jdk/javax/swing/JFileChooser/6698013/bug6698013.html

Lines changed: 0 additions & 31 deletions
This file was deleted.

test/jdk/javax/swing/JFileChooser/6698013/bug6698013.java

Lines changed: 38 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2008, 2024, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -21,41 +21,53 @@
2121
* questions.
2222
*/
2323

24-
/* @test
25-
@bug 6698013
26-
@summary JFileChooser can no longer navigate non-local file systems.
27-
@run applet/manual=done bug6698013.html
28-
*/
29-
3024
import java.io.File;
31-
32-
import javax.swing.JApplet;
3325
import javax.swing.JFileChooser;
3426
import javax.swing.SwingUtilities;
3527
import javax.swing.filechooser.FileSystemView;
3628

37-
public class bug6698013 extends JApplet {
38-
39-
final static VirtualFile root = new VirtualFile("testdir", true);
40-
41-
final static VirtualFile rootFile = new VirtualFile("testdir/test.txt", false);
29+
/*
30+
* @test
31+
* @bug 6698013
32+
* @library /java/awt/regtesthelpers
33+
* @build PassFailJFrame
34+
* @summary JFileChooser can no longer navigate non-local file systems.
35+
* @run main/manual bug6698013
36+
*/
4237

43-
final static VirtualFile subdir = new VirtualFile("testdir/subdir", true);
38+
public class bug6698013 {
4439

45-
final static VirtualFile subdirFile = new VirtualFile("testdir/subdir/subtest.txt", false);
40+
final static VirtualFile root = new VirtualFile("testdir", true);
4641

4742
public static void main(String[] args) throws Exception {
48-
SwingUtilities.invokeAndWait(() -> new bug6698013().init());
49-
}
50-
51-
public void init() {
52-
JFileChooser chooser = new JFileChooser(new VirtualFileSystemView());
53-
chooser.setCurrentDirectory(root);
54-
chooser.showOpenDialog(null);
43+
String instructions = """
44+
1. Go into 'subdir' folder via double click
45+
2. Return to parent directory
46+
3. Go into 'subdir' folder: select 'subdir' folder and press the 'Open' button
47+
If both methods of navigating into the subdir work, pass test. Otherwise fail.""";
48+
49+
PassFailJFrame pfframe = PassFailJFrame.builder()
50+
.title("bug6698013")
51+
.instructions(instructions)
52+
.rows(25)
53+
.columns(40)
54+
.testTimeOut(10)
55+
.build();
56+
57+
SwingUtilities.invokeAndWait(() -> {
58+
JFileChooser chooser = new JFileChooser(new VirtualFileSystemView());
59+
chooser.setCurrentDirectory(root);
60+
chooser.showOpenDialog(null);
61+
});
62+
63+
pfframe.awaitAndCheck();
5564
}
5665
}
5766

5867
class VirtualFileSystemView extends FileSystemView {
68+
final static VirtualFile rootFile = new VirtualFile("testdir/test.txt", false);
69+
final static VirtualFile subdir = new VirtualFile("testdir/subdir", true);
70+
final static VirtualFile subdirFile = new VirtualFile("testdir/subdir/subtest.txt", false);
5971

6072
public boolean isRoot(File dir) {
6173
return bug6698013.root.equals(dir);
@@ -87,11 +99,11 @@ public File getParentDirectory(File dir) {
8799

88100
public File[] getFiles(File dir, boolean hide_hidden) {
89101
if (dir.equals(bug6698013.root)) {
90-
return new File[]{bug6698013.rootFile, bug6698013.subdir};
102+
return new File[]{rootFile, subdir};
91103
}
92104

93-
if (dir.equals(bug6698013.subdir)) {
94-
return new File[]{bug6698013.subdirFile};
105+
if (dir.equals(subdir)) {
106+
return new File[]{subdirFile};
95107
}
96108

97109
return null;

0 commit comments

Comments
 (0)