Skip to content

Commit 1cf9755

Browse files
authored
Avoid calling getStackTrace when results are cached in RowCoderGenerator.generate (apache#34534)
1 parent 351fa66 commit 1cf9755

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoderGenerator.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,6 @@ static void clearRowCoderCache() {
199199

200200
@SuppressWarnings("unchecked")
201201
public static Coder<Row> generate(Schema schema) {
202-
String stackTrace = getStackTrace();
203202
UUID uuid = Preconditions.checkNotNull(schema.getUUID());
204203
// Avoid using computeIfAbsent which may cause issues with nested schemas.
205204
synchronized (cacheLock) {
@@ -268,6 +267,7 @@ public static Coder<Row> generate(Schema schema) {
268267
| InvocationTargetException e) {
269268
throw new RuntimeException("Unable to generate coder for schema " + schema, e);
270269
}
270+
String stackTrace = getStackTrace();
271271
GENERATED_CODERS.put(uuid, new WithStackTrace<>(rowCoder, stackTrace));
272272
LOG.debug(
273273
"Created row coder for uuid {} with encoding positions {} at {}",

0 commit comments

Comments
 (0)