Merge pull request #871 from jpurnell/fix/rss-xml-escaping

Fix XML escaping in RSS feed generator

Author: twostraws

Sources/Ignite/Publishing/FeedGenerator.swift

@@ -17,6 +17,15 @@ struct FeedGenerator {
         self.content = content
     }
 
+    private func xmlEscape(_ string: String) -> String {
+        string
+            .replacingOccurrences(of: "&", with: "&")
+            .replacingOccurrences(of: "<", with: "&lt;")
+            .replacingOccurrences(of: ">", with: "&gt;")
+            .replacingOccurrences(of: "\"", with: "&quot;")
+            .replacingOccurrences(of: "'", with: "&apos;")
+    }
+
     func generateFeed() -> String {
         let contentXML = generateContentXML()
         var result = generateRSSHeader()
@@ -25,7 +34,7 @@ struct FeedGenerator {
             result += """
             <image>\
             <url>\(image.url)</url>\
-            <title>\(site.name)</title>\
+            <title>\(xmlEscape(site.name))</title>\
             <link>\(site.url.absoluteString)</link>\
             <width>\(image.width)</width>\
             <height>\(image.height)</height>\

Tests/IgniteTesting/Publishing/FeedGenerator.swift

@@ -20,6 +20,21 @@ struct FeedGeneratorTests {
         TestSite(timeZone: .init(abbreviation: "EST")!)
     ]
 
+    @Test("XML-escapes special characters in titles")
+    func xmlEscapesSpecialCharacters() async throws {
+        let site = TestSite()
+        let config = site.feedConfiguration!
+        var article = Article()
+        article.title = "Donations & Sponsorships"
+        article.description = "Example Description"
+
+        let generator = FeedGenerator(config: config, site: site, content: [article])
+        let feed = generator.generateFeed()
+
+        #expect(feed.contains("<title>Donations &amp; Sponsorships</title>"))
+        #expect(!feed.contains("<title>Donations & Sponsorships</title>"))
+    }
+
     @Test("generateFeed()", arguments: await sites)
     func generateFeed(for site: any Site) async throws {
         let config = site.feedConfiguration!