Skip to content

Commit 9532cf2

Browse files
committed
ci: address CodeRabbit review findings
- Add permissions: contents: read (least-privilege GITHUB_TOKEN) - Add persist-credentials: false to all checkout steps - Add concurrency group to cancel superseded CI runs - Fix pre-release-hook: use --tag v{{version}} instead of --latest (--latest resolves the previous tag since the new tag doesn't exist yet during cargo-release's pre-release-hook)
1 parent e2ae129 commit 9532cf2

2 files changed

Lines changed: 16 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ on:
66
pull_request:
77
branches: [main]
88

9+
permissions:
10+
contents: read
11+
12+
concurrency:
13+
group: ci-${{ github.ref }}
14+
cancel-in-progress: true
15+
916
env:
1017
CARGO_TERM_COLOR: always
1118

@@ -16,6 +23,8 @@ jobs:
1623
runs-on: ubuntu-latest
1724
steps:
1825
- uses: actions/checkout@v4
26+
with:
27+
persist-credentials: false
1928
- uses: dtolnay/rust-toolchain@1.91
2029
with:
2130
components: rustfmt
@@ -29,6 +38,8 @@ jobs:
2938
SQLX_OFFLINE: true
3039
steps:
3140
- uses: actions/checkout@v4
41+
with:
42+
persist-credentials: false
3243
- uses: dtolnay/rust-toolchain@1.91
3344
with:
3445
components: clippy
@@ -45,6 +56,8 @@ jobs:
4556
os: [ubuntu-latest, macos-latest, windows-latest]
4657
steps:
4758
- uses: actions/checkout@v4
59+
with:
60+
persist-credentials: false
4861
- uses: dtolnay/rust-toolchain@1.91
4962
- uses: Swatinem/rust-cache@v2
5063
- run: cargo test --all-targets --all-features
@@ -54,4 +67,6 @@ jobs:
5467
runs-on: ubuntu-latest
5568
steps:
5669
- uses: actions/checkout@v4
70+
with:
71+
persist-credentials: false
5772
- run: test/integration.sh

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,5 +72,5 @@ pre-release-hook = [
7272
"cliff",
7373
"-o",
7474
"CHANGELOG.md",
75-
"--latest",
75+
"--tag", "v{{version}}",
7676
]

0 commit comments

Comments
 (0)