Skip to content

Commit 967bc92

Browse files
unsent_saves(): scan every review lane, not just HEAD
`git log HEAD --not --remotes` is bounded by HEAD's ancestry, so with the checkout on any branch other than the reviewer's lane their saves become invisible. The docstring claimed the opposite -- "deliberately not filtered to this branch either" -- which is what made this hard to spot. Measured today with the repo left on `main`: 0 unsent saves reported while 6 sat on `review/vijay-tylertech/08282026-121644`, and the Save page read "Nothing waiting. Everything reviewed has been sent in." That is the worst possible failure for this indicator specifically. It is the one thing a reviewer checks to confirm their work still exists, and it told them it did not -- while the six commits holding four knowledge-file edits were sitting in the repo the whole time. `--branches=review/*` rather than `--branches`: machinery branches (feature/, fix/) are not saves, and listing them would report the tool's own development as the reviewer's pending work. Verified: 6 reported from `main`, matching `git log --branches='review/*' --not --remotes` exactly, where the old form reported 0. Claude-Session: https://claude.ai/code/session_01VVNYqGza2dFdeWFX7qXnwb
1 parent 0e2582b commit 967bc92

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

scripts/review_server.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4832,14 +4832,21 @@ def unsent_saves():
48324832
- comparing against `origin/<current branch>` fails for the same reason, and silently -
48334833
the missing ref just makes the "already sent" set empty and everything looks unsent.
48344834

4835-
Deliberately not filtered to this branch either. If a save was made on one lane and the
4836-
reviewer has since moved, it is still their unsent work and still needs sending.
4835+
SCANS EVERY REVIEW LANE, not just HEAD - and the previous version claimed to while doing the
4836+
opposite. `git log HEAD --not --remotes` is bounded by HEAD's ancestry, so with the checkout
4837+
on any other branch a reviewer's saves become invisible: measured 2026-08-30 with the repo
4838+
left on `main`, this reported 0 unsent saves while 6 sat on
4839+
`review/vijay-tylertech/08282026-121644`, and the Save page said "Nothing waiting." That is
4840+
the worst possible failure for this particular indicator - it is the one thing a reviewer
4841+
would check to confirm their work still exists, and it told them it did not.
4842+
`review/*` and not `--branches`, because machinery branches (feature/, fix/) are not saves
4843+
and listing them here would report the tool's own development as the reviewer's pending work.
48374844

48384845
No fetch: this runs on every page render, and a network call would hang the page on a bad
48394846
connection. It uses the last-known remote state, like the rest of the page.
48404847
"""
48414848
rc, out = git("log", "--format=%h%x09%ad%x09%s", "--date=format:%m/%d %H:%M",
4842-
"HEAD", "--not", "--remotes")
4849+
"HEAD", "--branches=review/*", "--not", "--remotes")
48434850
if rc != 0 or not out.strip():
48444851
return []
48454852
rows = []

0 commit comments

Comments
 (0)