Commit 967bc92
committed
unsent_saves(): scan every review lane, not just HEAD
`git log HEAD --not --remotes` is bounded by HEAD's ancestry, so with the checkout on
any branch other than the reviewer's lane their saves become invisible. The docstring
claimed the opposite -- "deliberately not filtered to this branch either" -- which is
what made this hard to spot.
Measured today with the repo left on `main`: 0 unsent saves reported while 6 sat on
`review/vijay-tylertech/08282026-121644`, and the Save page read "Nothing waiting.
Everything reviewed has been sent in."
That is the worst possible failure for this indicator specifically. It is the one
thing a reviewer checks to confirm their work still exists, and it told them it did
not -- while the six commits holding four knowledge-file edits were sitting in the
repo the whole time.
`--branches=review/*` rather than `--branches`: machinery branches (feature/, fix/)
are not saves, and listing them would report the tool's own development as the
reviewer's pending work.
Verified: 6 reported from `main`, matching `git log --branches='review/*' --not
--remotes` exactly, where the old form reported 0.
Claude-Session: https://claude.ai/code/session_01VVNYqGza2dFdeWFX7qXnwb1 parent 0e2582b commit 967bc92
1 file changed
Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4832 | 4832 | | |
4833 | 4833 | | |
4834 | 4834 | | |
4835 | | - | |
4836 | | - | |
| 4835 | + | |
| 4836 | + | |
| 4837 | + | |
| 4838 | + | |
| 4839 | + | |
| 4840 | + | |
| 4841 | + | |
| 4842 | + | |
| 4843 | + | |
4837 | 4844 | | |
4838 | 4845 | | |
4839 | 4846 | | |
4840 | 4847 | | |
4841 | 4848 | | |
4842 | | - | |
| 4849 | + | |
4843 | 4850 | | |
4844 | 4851 | | |
4845 | 4852 | | |
| |||
0 commit comments