Skip to content

Commit 8de9d9a

Browse files
authored
Allow None on view_on_site (#2419)
This makes it consistent with `get_view_on_site_url` signature where it is used.
1 parent 82cb4c0 commit 8de9d9a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: django-stubs/contrib/admin/options.pyi

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ class BaseModelAdmin(Generic[_ModelT]):
139139
def has_view_or_change_permission(self, request: HttpRequest, obj: _ModelT | None = ...) -> bool: ...
140140
def has_module_permission(self, request: HttpRequest) -> bool: ...
141141
@property
142-
def view_on_site(self) -> Callable[[_ModelT], str] | bool: ...
142+
def view_on_site(self) -> Callable[[_ModelT], str | None] | bool: ...
143143

144144
_ModelAdmin = TypeVar("_ModelAdmin", bound=ModelAdmin[Any])
145145
_ActionCallable: TypeAlias = Callable[[_ModelAdmin, HttpRequest, QuerySet[_ModelT]], HttpResponseBase | None]

0 commit comments

Comments
 (0)