Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make APISettings a generic class. #375

Open
PedroPerpetua opened this issue Mar 14, 2023 · 0 comments
Open

[Enhancement] Make APISettings a generic class. #375

PedroPerpetua opened this issue Mar 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@PedroPerpetua
Copy link

PedroPerpetua commented Mar 14, 2023

Some modules designed to work with DRF subclass the restframework.settings.APISettings class to implement their own custom settings (for example, djangorestframework-simplejwt). This class has the expected settings keys "hardcoded" into the class itself, making subclasses have to type-ignore when using their own Settings TypedDict or have some incompatible override.

The class could be made generic so subclasses pass their own TypedDict of settings.

@intgr intgr added the enhancement New feature or request label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants