feat(remark): refactor remark-toc implementation

tgreyuk · tgreyuk · commit 31d39eeb96ea · 2024-12-22T21:29:41.000Z
diff --git a/devtools/packages/prebuild-options/tasks/generate-models.ts b/devtools/packages/prebuild-options/tasks/generate-models.ts
@@ -5,11 +5,7 @@ import * as path from 'path';
 import * as prettier from 'prettier';
 import { DeclarationOption, ParameterType } from 'typedoc';
 
-const ignoreTypes = [
-  'textContentMappings',
-  'remarkPlugins',
-  'remarkStringifyOptions',
-];
+const ignoreTypes = ['textContentMappings', 'remarkStringifyOptions'];
 
 export async function generateOptionsModels(docsConfig: DocsConfig) {
   const optionsConfig = await import(docsConfig.declarationsPath as string);
@@ -34,7 +30,7 @@ async function writeTypeDocDeclarations(
         (option as any).type === ParameterType.Mixed &&
         (option as any).defaultValue,
     )
-    .map(([name, option]) => capitalize(name));
+    .map(([name, option]) => capitalize(name, false));
 
   const out: string[] = [];
 
@@ -126,17 +122,20 @@ ${name}: ${getType(name, option, true)};`,
     ?.filter(([name]) => !ignoreTypes.includes(name))
     .map(([name, option]) => {
       return `
-  /**
-   * ${getComments(name)}
-   */
-  export interface ${capitalize(name)} {
+    ${
+      // this is a hack need to fix properly
+      name === 'remarkPlugins'
+        ? 'export type RemarkPlugin = string | [string, Record<string, any>];'
+        : `export interface ${capitalize(name)} {
       ${Object.entries(option.defaultValue as any)
         .map(
           ([key, value]) =>
             `'${key}'${value === undefined ? '?' : ''}: ${getValueType(key, value)}`,
         )
         .join(';')}
-  }
+  }`
+    }
+
     `;
     })
     .join('\n')}
@@ -255,6 +254,9 @@ function getObjectType(name: string) {
   return 'string';
 }
 
-function capitalize(str: string) {
+function capitalize(str: string, includeArray = true) {
+  if (str.endsWith('s')) {
+    str = `${str.slice(0, -1)}${includeArray ? '[]' : ''}`;
+  }
   return str.charAt(0).toUpperCase() + str.slice(1);
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/typedoc-plugin-remark/package.json b/packages/typedoc-plugin-remark/package.json
@@ -14,6 +14,7 @@
     "prepublishOnly": "npm run lint && npm run build",
     "prebuild": "rm -rf dist && prebuild-options",
     "build": "tsc",
+    "build-and-run": "npm run build && npm run pretest",
     "pretest": "tsx ./test/__scripts__/prepare.ts",
     "test": "jest",
     "test:update": "npm run build && npm run test -- -u"
@@ -31,7 +32,8 @@
     "remark-frontmatter": "^5.0.0",
     "remark-gfm": "^4.0.0",
     "remark-mdx": "^3.1.0",
-    "to-vfile": "^8.0.0"
+    "to-vfile": "^8.0.0",
+    "unist-util-visit": "^5.0.0"
   },
   "peerDependencies": {
     "typedoc-plugin-markdown": ">=4.3.0"
diff --git a/packages/typedoc-plugin-remark/src/_typedoc.d.ts b/packages/typedoc-plugin-remark/src/_typedoc.d.ts
@@ -1,9 +1,10 @@
 // THIS FILE IS AUTO GENERATED FROM THE OPTIONS CONFIG. DO NOT EDIT DIRECTLY.
 import { ManuallyValidatedOption } from 'typedoc';
+import { RemarkPlugin } from './types/options.js';
 declare module 'typedoc' {
   export interface TypeDocOptionMap {
     defaultRemarkPlugins: { gfm: boolean; frontmatter: boolean; mdx: boolean };
-    remarkPlugins: ManuallyValidatedOption<Partial<any>>;
+    remarkPlugins: ManuallyValidatedOption<RemarkPlugin[]>;
     remarkStringifyOptions: ManuallyValidatedOption<Record<string, any>>;
   }
 }
diff --git a/packages/typedoc-plugin-remark/src/helpers/add-toc.ts b/packages/typedoc-plugin-remark/src/helpers/add-toc.ts
diff --git a/packages/typedoc-plugin-remark/src/helpers/get-default-plugins.ts b/packages/typedoc-plugin-remark/src/helpers/get-default-plugins.ts
@@ -1,4 +1,4 @@
-import { RemarkPlugin } from '../types/remark-plugin.js';
+import { RemarkPlugin } from '../types/options.js';
 
 export function getDefaultPlugins(defaultPluginsFlag: {
   gfm: boolean;
diff --git a/packages/typedoc-plugin-remark/src/index.ts b/packages/typedoc-plugin-remark/src/index.ts
@@ -4,13 +4,16 @@
  * @module
  */
 
+import * as path from 'path';
 import { Application, DeclarationOption, RendererEvent } from 'typedoc';
-import { MarkdownPageEvent } from 'typedoc-plugin-markdown';
-import { addTableOfContents } from './helpers/add-toc.js';
+import { fileURLToPath } from 'url';
 import { getDefaultPlugins } from './helpers/get-default-plugins.js';
 import * as options from './options/declarations.js';
 import { parse } from './parse.js';
 
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+
 export function load(app: Application) {
   Object.entries(options).forEach(([name, option]) => {
     app.options.addDeclaration({
@@ -19,28 +22,37 @@ export function load(app: Application) {
     } as DeclarationOption);
   });
 
-  app.renderer.on(MarkdownPageEvent.END, (event: MarkdownPageEvent) => {
-    const remarkPlugins = app.options.getValue('remarkPlugins') as [];
-    const remarkPluginsNames = remarkPlugins.map((plugin) =>
-      Array.isArray(plugin) ? plugin[0] : plugin,
-    ) as string[];
-
-    if (remarkPluginsNames.includes('remark-toc')) {
-      addTableOfContents(event, remarkPlugins, remarkPluginsNames, app);
-    }
-  });
-
   app.renderer.postRenderAsyncJobs.push(async (output: RendererEvent) => {
+    const remarkPlugins = app.options.getValue('remarkPlugins') as [];
     const defaultPlugins = getDefaultPlugins(
       app.options.getValue('defaultRemarkPlugins'),
     );
     const userPlugins = app.options.getValue('remarkPlugins') as string[];
     const remarkStringifyOptions = app.options.getValue(
       'remarkStringifyOptions',
     );
+    const remarkPluginsNames = remarkPlugins.map((plugin) =>
+      Array.isArray(plugin) ? plugin[0] : plugin,
+    ) as string[];
+
     if (output.urls?.length) {
       await Promise.all(
         output.urls?.map(async (urlMapping) => {
+          if (remarkPluginsNames.includes('remark-toc')) {
+            const tocPluginIndex = remarkPluginsNames.findIndex(
+              (name) => name === 'remark-toc',
+            );
+            const tocPlugin = remarkPlugins[tocPluginIndex];
+            const tocOptions = Array.isArray(tocPlugin) ? tocPlugin[1] : {};
+            defaultPlugins.push([
+              path.join(__dirname, 'plugins', 'add-toc.js'),
+              {
+                reflection: urlMapping.model,
+                typedocOptions: app.options,
+                tocOptions,
+              },
+            ]);
+          }
           const filePath = `${output.outputDirectory}/${urlMapping.url}`;
           return await parse(
             filePath,
diff --git a/packages/typedoc-plugin-remark/src/options/index.ts b/packages/typedoc-plugin-remark/src/options/index.ts
@@ -4,5 +4,4 @@
  * @module
  */
 
-export * as helpers from '../helpers/add-toc.js';
 export * as declarations from './declarations.js';
diff --git a/packages/typedoc-plugin-remark/src/parse.ts b/packages/typedoc-plugin-remark/src/parse.ts
@@ -1,7 +1,7 @@
 import * as path from 'path';
 import { remark } from 'remark';
 import { read, writeSync } from 'to-vfile';
-import { RemarkPlugin } from './types/remark-plugin.js';
+import { RemarkPlugin } from './types/options.js';
 
 export async function parse(
   filePath: string,
diff --git a/packages/typedoc-plugin-remark/src/plugins/add-toc.ts b/packages/typedoc-plugin-remark/src/plugins/add-toc.ts
@@ -0,0 +1,62 @@
+import { Heading } from 'mdast';
+import { DeclarationReflection, Options, ReflectionKind } from 'typedoc';
+import { Node } from 'unist';
+import { visit } from 'unist-util-visit';
+
+/**
+ * This plugin is used internally to add a toc heading as required to be present in the page when using the remark-toc plugin.
+ */
+export default function (options: any) {
+  const { reflection, typedocOptions, tocOptions } = options;
+
+  return (tree: Node) => {
+    // If the current page is already an index page, do nothing.
+    if (isIndexPage(reflection, typedocOptions)) {
+      return tree;
+    }
+    visit(
+      tree,
+      'heading',
+      (node: Heading, index, parent: { children: Node[] }) => {
+        if (node.depth === 2) {
+          const newHeading: Heading = {
+            type: 'heading',
+            depth: 2,
+            children: [
+              {
+                type: 'text',
+                value: tocOptions?.heading || 'Contents',
+              },
+            ],
+          };
+          parent?.children.splice(index, 0, newHeading);
+          return false;
+        }
+      },
+    );
+  };
+}
+
+/**
+ * Determine if the current page is already an index page.
+ * - Reflection is a project and all children are modules.
+ * - Reflection is a module and outputFileStrategy is equal to "members".
+ */
+function isIndexPage(
+  reflection: DeclarationReflection,
+  typedocOptions: Options,
+) {
+  if (
+    reflection.kind === ReflectionKind.Project &&
+    reflection.children?.every((child) => child.kind === ReflectionKind.Module)
+  ) {
+    return true;
+  }
+  if (
+    [ReflectionKind.Project, ReflectionKind.Module].includes(reflection.kind) &&
+    typedocOptions?.getValue('outputFileStrategy') === 'members'
+  ) {
+    return true;
+  }
+  return false;
+}
diff --git a/packages/typedoc-plugin-remark/src/types/options.ts b/packages/typedoc-plugin-remark/src/types/options.ts
@@ -13,10 +13,12 @@ export interface PluginOptions {
   /**
    * An array of remark plugin names to be executed.
    */
-  remarkPlugins: any;
+  remarkPlugins: RemarkPlugin[];
 
   /**
    * Custom options for the remark-stringify plugin.
    */
   remarkStringifyOptions: Record<string, any>;
 }
+
+export type RemarkPlugin = string | [string, Record<string, any>];
diff --git a/packages/typedoc-plugin-remark/src/types/remark-plugin.ts b/packages/typedoc-plugin-remark/src/types/remark-plugin.ts
diff --git a/packages/typedoc-plugin-remark/test/__scripts__/prepare.ts b/packages/typedoc-plugin-remark/test/__scripts__/prepare.ts
@@ -12,9 +12,10 @@ fs.removeSync(`./test/out`);
 const fixtures = [
   { options: 'typedoc.modules.json', outDir: 'modules' },
   { options: 'typedoc.members.json', outDir: 'members' },
+  { options: 'typedoc.toc.json', outDir: 'toc' },
   { options: 'typedoc.globals.json', outDir: 'globals' },
-  { options: 'typedoc.globals-notoc.json', outDir: 'globals-notoc' },
   { options: 'typedoc.globals-mdx.json', outDir: 'globals-mdx' },
+  { options: 'typedoc.globals-notoc.json', outDir: 'globals-notoc' },
 ];
 
 // write fixtures
diff --git a/packages/typedoc-plugin-remark/test/stubs/module-toc.ts b/packages/typedoc-plugin-remark/test/stubs/module-toc.ts
@@ -0,0 +1,31 @@
+/**
+ * @module
+ */
+
+export const someVariable = true;
+
+export const someFunction = (a: string, b: number) => {
+  return true;
+};
+
+export class Class {
+  a: string;
+  b: number;
+}
+
+export type SimpleTypeAlias = string | boolean;
+
+export type TypeAliasWithTypeDeclaration = {
+  a: string;
+  b: number;
+};
+
+export interface Interface {
+  a: string;
+  b: number;
+}
+
+export enum Enum {
+  A,
+  B,
+}
diff --git a/packages/typedoc-plugin-remark/test/typedoc.base.json b/packages/typedoc-plugin-remark/test/typedoc.base.json
@@ -1,5 +1,5 @@
 {
-  "entryPoints": ["./stubs/*.ts"],
+  "entryPoints": ["./stubs/module-1.ts", "./stubs/module-2.ts"],
   "tsconfig": "./stubs/tsconfig.json",
   "out": "./out",
   "plugin": [
diff --git a/packages/typedoc-plugin-remark/test/typedoc.members.json b/packages/typedoc-plugin-remark/test/typedoc.members.json
@@ -1,6 +1,5 @@
 {
   "extends": "./typedoc.base.json",
-  "entryPoints": ["./stubs/*.ts"],
   "remarkPlugins": ["remark-github", ["remark-toc", { "maxDepth": 3 }]],
   "defaultRemarkPlugins": {
     "mdx": false
diff --git a/packages/typedoc-plugin-remark/test/typedoc.modules.json b/packages/typedoc-plugin-remark/test/typedoc.modules.json
diff --git a/packages/typedoc-plugin-remark/test/typedoc.toc.json b/packages/typedoc-plugin-remark/test/typedoc.toc.json

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,10 @@`
`1`	`1`	`// THIS FILE IS AUTO GENERATED FROM THE OPTIONS CONFIG. DO NOT EDIT DIRECTLY.`
`2`	`2`	`import { ManuallyValidatedOption } from 'typedoc';`
	`3`	`+import { RemarkPlugin } from './types/options.js';`
`3`	`4`	`declare module 'typedoc' {`
`4`	`5`	`export interface TypeDocOptionMap {`
`5`	`6`	`defaultRemarkPlugins: { gfm: boolean; frontmatter: boolean; mdx: boolean };`
`6`		`- remarkPlugins: ManuallyValidatedOption<Partial<any>>;`
	`7`	`+ remarkPlugins: ManuallyValidatedOption<RemarkPlugin[]>;`
`7`	`8`	`remarkStringifyOptions: ManuallyValidatedOption<Record<string, any>>;`
`8`	`9`	`}`
`9`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { RemarkPlugin } from '../types/remark-plugin.js';`
	`1`	`+import { RemarkPlugin } from '../types/options.js';`
`2`	`2`
`3`	`3`	`export function getDefaultPlugins(defaultPluginsFlag: {`
`4`	`4`	`gfm: boolean;`