Merge pull request #3136 from armanbilge/pr/fix-chunk-tobytevector-bytebuffer-linking

mpilquist · web-flow · commit d7336162a3fe · 2023-02-09T08:59:21.000-05:00
Fix `ByteBuffer` linking in `Chunk#toByteVector`
diff --git a/core/shared/src/main/scala/fs2/Chunk.scala b/core/shared/src/main/scala/fs2/Chunk.scala
@@ -889,8 +889,8 @@ object Chunk
 
     override def toByteVector[B >: Byte](implicit ev: B =:= Byte): ByteVector = {
       val bb = buf.asReadOnlyBuffer()
-      bb.position(offset)
-      bb.limit(offset + size)
+      (bb: JBuffer).position(offset)
+      (bb: JBuffer).limit(offset + size)
       ByteVector.view(bb)
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -889,8 +889,8 @@ object Chunk`
`889`	`889`
`890`	`890`	`override def toByteVector[B >: Byte](implicit ev: B =:= Byte): ByteVector = {`
`891`	`891`	`val bb = buf.asReadOnlyBuffer()`
`892`		`- bb.position(offset)`
`893`		`- bb.limit(offset + size)`
	`892`	`+ (bb: JBuffer).position(offset)`
	`893`	`+ (bb: JBuffer).limit(offset + size)`
`894`	`894`	`ByteVector.view(bb)`
`895`	`895`	`}`
`896`	`896`	`}`