Skip to content

Commit 86d0c26

Browse files
committed
feat: rename _embed to _dependent for delete action
1 parent 3710dce commit 86d0c26

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ GET /comments?_embed=post
169169

170170
```
171171
DELETE /posts/1
172-
DELETE /posts/1?_embed=comments
172+
DELETE /posts/1?_dependent=comments
173173
```
174174

175175
## Serving static files

src/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ export function createApp(db: Low<Data>, options: AppOptions = {}) {
110110

111111
app.delete('/:name/:id', async (req, res, next) => {
112112
const { name = '', id = '' } = req.params
113-
res.locals['data'] = await service.destroyById(name, id)
113+
res.locals['data'] = await service.destroyById(name, id, req.query['dependent'])
114114
next()
115115
})
116116

src/service.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export class Service {
171171
name: string,
172172
query: {
173173
[key: string]: unknown
174-
_embed?: string[]
174+
_embed?: string | string[]
175175
_sort?: string
176176
_start?: number
177177
_end?: number
@@ -424,7 +424,7 @@ export class Service {
424424
async destroyById(
425425
name: string,
426426
id: string,
427-
dependents: string[] = [],
427+
dependent?: string | string[],
428428
): Promise<Item | undefined> {
429429
const items = this.#get(name)
430430
if (items === undefined || !Array.isArray(items)) return
@@ -435,6 +435,7 @@ export class Service {
435435
items.splice(index, 1)[0]
436436

437437
nullifyForeignKey(this.#db, name, id)
438+
const dependents = ensureArray(dependent)
438439
deleteDependents(this.#db, name, dependents)
439440

440441
await this.#db.write()

0 commit comments

Comments
 (0)