Skip to content

build fail due to duplication with dayjs #205

Open
@Goldziher

Description

@Goldziher

Hi there. First thanks for this nice package. We are using it for the vuex bindings only though, and the added stuff is creating some problems:

ERROR in /var/www/yoda/node_modules/@u3u/vue-hooks/node_modules/dayjs/locale/index.d.ts(10,12):

10:12 Duplicate identifier 'locale'.

     8 |   const locale: locale.Locale

     9 | 

  > 10 |   export = locale

       |            ^

    11 | }

    12 | 



 error  in /var/www/yoda/node_modules/dayjs/locale/index.d.ts



ERROR in /var/www/yoda/node_modules/dayjs/locale/index.d.ts(10,12):

10:12 Duplicate identifier 'locale'.

     8 |   const locale: locale.Locale

     9 | 

  > 10 |   export = locale

       |            ^

    11 | }

    12 | 

I'd suggest moving dayjs into a peer dependency, or completely removing this hook from the package - after all, users might use a different library or a native implementation etc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions