Skip to content

Commit 6b21379

Browse files
Fix: increase fasthttp ReadBufferSize to handle large GitHub headers (#44)
1 parent 430c65c commit 6b21379

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

internal/oauth2/github/github.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@ import (
1212
"github.com/valyala/fasthttp"
1313
)
1414

15+
var (
16+
defaultClient = &fasthttp.Client{
17+
ReadBufferSize: 16 * 1024,
18+
}
19+
)
20+
1521
func User(secret oauth2.Secret, code string) (result oauth2.SocialProviderUser, err error) {
1622
accessTokenResponse, err := getAccessToken(secret, code)
1723
if err != nil {
@@ -68,7 +74,7 @@ func getAccessToken(secret oauth2.Secret, code string) (result github.AccessToke
6874
q.Add("client_secret", secret.ClientSecret)
6975
q.Add("code", code)
7076

71-
err = fasthttp.Do(request, response)
77+
err = defaultClient.Do(request, response)
7278
if err != nil {
7379
return result, fmt.Errorf("GitHub (get access token) http err %v", err)
7480
}
@@ -99,7 +105,7 @@ func getUser(accessToken string) (result github.User, err error) {
99105
request.SetRequestURI(github.ApiUserURI)
100106
request.Header.Set("Authorization", "token "+accessToken)
101107

102-
err = fasthttp.Do(request, response)
108+
err = defaultClient.Do(request, response)
103109
if err != nil {
104110
return result, fmt.Errorf("GitHub (get user) http err %v", err)
105111
}

0 commit comments

Comments
 (0)