Does Piranha support scala projects

[eankit]

Does Piranha have support for scala with current code or can it be supported with minimalistic changes in java?

[mkr-plse]

You can potentially add rules for Scala and make Piranha applicable for Scala. See here

[ketkarameya]

@eankit you can use https://github.com/tree-sitter/tree-sitter-scala for the grammar. I think the rules will be very similar to the ones implemented for Java/Kotlin.

[eankit]

can some help with how to and where to make changes in .rs files in the polygot piranha. I understand the .toml file syntaxes but it seems a lot goes into .rs files before it could be used in the toml file.
@ketkarameya @mkr-plse

[ketkarameya]

@eankit adding new language support requires very minimal changes .rs files . I am streamlining the implementation here - #283.

After this merges, it should be easy (though slightly tedious) to add scala support. I will update the README and keep you posted.

Basically you will have to do the following:

1. Add configurations for Scala (like the parser, rules, )
2. Write rules for cleaning up potentially stale code (You can get "inspiration" from our java or kotlin rules :) )
3. Write tests to show that your rules work.

[eankit]

Hey @ketkarameya
I am getting this error while building the latest code on master, similar error is seen if I add scala as new language along with typescript, removing the ts and TSX language specific code from language.rs things seems to work fine.
What am I doing wrong

_Building wheels for collected packages: polyglot_piranha
Building wheel for polyglot_piranha (pyproject.toml) ... error
error: subprocess-exited-with-error

× Building wheel for polyglot_piranha (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [33 lines of output]
Running maturin pep517 build-wheel -i /Users/anbhanda/Documents/Pirahnah_Polygot/piranha/polyglot/piranha/.env/bin/python3 --compatibility off
📡 Using build options bindings from pyproject.toml
Compiling piranha v0.2.1 (/Users/anbhanda/Documents/Pirahnah_Polygot/piranha/polyglot/piranha)
error: could not compile piranha due to 3 previous errors
💥 maturin failed
Caused by: Failed to build a native library through cargo
Caused by: Cargo build finished with "exit status: 101": "cargo" "rustc" "--release" "--message-format" "json" "--lib" "--" "-C" "link-arg=-undefined" "-C" "link-arg=dynamic_lookup" "-C" "link-args=-Wl,-install_name,@rpath/polyglot_piranha.cpython-38-darwin.so"
🔗 Found pyo3 bindings
🐍 Found CPython 3.8 at /Users/anbhanda/Documents/Pirahnah_Polygot/piranha/polyglot/piranha/.env/bin/python3
error[E0308]: mismatched types
--> src/models/language.rs:154:19
|
154 | language: tree_sitter_typescript::language_typescript(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct tree_sitter::Language, found a different struct tree_sitter::Language
|
= note: perhaps two different versions of crate tree_sitter are being used?

  error[E0308]: mismatched types
     --> src/models/language.rs:163:19
      |
  163 |         language: tree_sitter_typescript::language_tsx(),
      |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `tree_sitter::Language`, found a different struct `tree_sitter::Language`
      |
      = note: perhaps two different versions of crate `tree_sitter` are being used?
  
  
  error: aborting due to 2 previous errors
  
  
  For more information about this error, try `rustc --explain E0308`.
  
  Error: command ['maturin', 'pep517', 'build-wheel', '-i', '/Users/anbhanda/Documents/Pirahnah_Polygot/piranha/polyglot/piranha/.env/bin/python3', '--compatibility', 'off'] returned non-zero exit status 1
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for polyglot_piranha
Failed to build polyglot_piranha
ERROR: Could not build wheels for polyglot_piranha, which is required to install pyproject.toml-based projects_

[ketkarameya]

I assume you get this error on adding the tree-sitter-scala right? I think there is a tree sitter version mismatch. How have u added it in Cargo.toml? Can you add the GitHub repo link there (like tree-sitter-java )

[eankit]

@ketkarameya I have added the it in Cargo.toml, I have added the one mentioned above -
My cargo.toml looks like this -
tree-sitter-kotlin = { git = "https://github.com/ketkarameya/tree-sitter-kotlin.git" }
tree-sitter-java = { git = "https://github.com/tree-sitter/tree-sitter-java.git" }
tree-sitter-swift = { git = "https://github.com/ketkarameya/tree-sitter-swift.git", branch = "add_parser" }
tree-sitter-strings = { git = "https://github.com/ketkarameya/tree-sitter-strings.git" }
tree-sitter-python = { git = "https://github.com/tree-sitter/tree-sitter-python.git" }
tree-sitter-go = { git = "https://github.com/tree-sitter/tree-sitter-go.git" }
tree-sitter-typescript = { git = "https://github.com/tree-sitter/tree-sitter-typescript.git" }
tree-sitter-scala = { git = "https://github.com/tree-sitter/tree-sitter-scala.git" }

[eankit]

@ketkarameya upon fetching the latest pull from master, I am getting this error without adding scala. This error is coming for typescript also up doing a pip install .

[ketkarameya]

But the CI is passing . What machine are you using ? ubuntu /mac / windows?

[eankit]

I am on my local mac

[ketkarameya]

So you are able to build the application locally (with no changes)?

[eankit]

no I have to make some change to run it locally, if I remove typescript from your code/master it is building code correctly

[eankit]

@ketkarameya after making the below change I am able to run the pip install . successfully

diff --git a/polyglot/piranha/src/models/language.rs b/polyglot/piranha/src/models/language.rs
index d5a90fc..639e371 100644
--- a/polyglot/piranha/src/models/language.rs
+++ b/polyglot/piranha/src/models/language.rs
@@ -148,24 +148,6 @@ impl From<&str> for PiranhaLanguage {
scopes: vec![],
comment_nodes: vec![],
},

•  "ts" => PiranhaLanguage {
  

•    name: language.to_string(),
  

•    supported_language: SupportedLanguage::Ts,
  

•    language: tree_sitter_typescript::language_typescript(),
  

•    rules: None,
  

•    edges: None,
  

•    scopes: vec![],
  

•    comment_nodes: vec![],
  

•  },
  

•  "tsx" => PiranhaLanguage {
  

•    name: language.to_string(),
  

•    supported_language: SupportedLanguage::Tsx,
  

•    language: tree_sitter_typescript::language_tsx(),
  

•    rules: None,
  

•    edges: None,
  

•    scopes: vec![],
  

•    comment_nodes: vec![],
  

•  },
   _ => panic!("Language not supported"),
  

  }
  }

[ketkarameya]

I am using a Mac too. I did the following

1. git clone ...
2. cd piranha/polyglot/piranha directory.
   Then ran the command cargo build --no-default-features (which ran successfully)

Are you doing the same?