Use addLineBottom instead of replaceLines

This makes sure that lines are only added through the Lines.addLast()
interface.

Author: jspricke

app/src/main/java/com/ubergeek42/WeechatAndroid/relay/Buffer.kt

@@ -209,13 +209,9 @@ class Buffer @WorkerThread constructor(
     /////////////////////////////////////////////////////////////// stuff called by message handlers
     ////////////////////////////////////////////////////////////////////////////////////////////////
 
-    @WorkerThread @Synchronized fun replaceLines(newLines: Collection<Line>) {
-        if (isOpen) {
-            newLines.forEach { it.ensureSpannable() }
-        }
-
+    @WorkerThread @Synchronized fun clearLines() {
         synchronized(this) {
-            lines.replaceLines(newLines)
+            lines.clearLines()
         }
    }
 

app/src/main/java/com/ubergeek42/WeechatAndroid/relay/BufferList.kt

@@ -385,13 +385,12 @@ object BufferList {
     private class LineListingHandler(private val bufferPointer: Long) : HdataHandler {
         override fun handleMessage(obj: Hdata, id: String) {
             findByPointer(bufferPointer)?.let { buffer ->
-                val newLines = ArrayList<Line>(obj.count)
 
+                buffer.clearLines()
                 obj.forEachReversed { entry ->
-                    newLines.add(LineSpec(entry).toLine())
+                    buffer.addLineBottom(LineSpec(entry).toLine())
                 }
 
-                buffer.replaceLines(newLines)
                 buffer.onLinesListed()
             }
         }

app/src/main/java/com/ubergeek42/WeechatAndroid/relay/Lines.kt

@@ -87,14 +87,10 @@ class Lines {
     // in very rare cases status might not be FETCHING here, particularly when closing buffers
     // while the app is connecting and has already requested lines
 
-    fun replaceLines(lines: Collection<Line>) {
+    fun clearLines() {
         if (status != Status.Fetching) return
         unfiltered.clear()
         filtered.clear()
-        unfiltered.addAll(lines)
-        for (line in lines) {
-            if (line.isVisible) filtered.add(line)
-        }
     }
 
     fun addLast(line: Line) {