Investigate and confirm the behaviour for new staking users for uad-contracts and diamond

[gitcoindev]

Right now the behaviour for new staking users is this one:

1. User deposits 1000 UAD3CRV LP to https://etherscan.io/address/0xc251ecd9f1bd5230823f9a0f99a44a87ddd4ca38 for 1 week
2. User waits for 1 week
3. User withdraws 1000 UAD3CRV LP and gets 178 UAD3CRV LP + 72 UBQ. User would expect to get 1000 UAD3CRV LP instead of 178.

Originally posted by @rndquu in #752 (comment)

[gitcoindev]

I extracted this to a separate issue, will post finding for both uad-contracts and diamond-based staking contract.

[0x4007]

I'm assuming its because I moved collateral out of the contract which I know affects the withdrawal amounts.

[ubiquity-os]

# Issue was not closed as completed. Skipping.

[rndquu]

I'm assuming its because I moved collateral out of the contract which I know affects the withdrawal amounts.

Do we plan to move it back to the staking contract?

[0x4007]

Yeah I think we need to migrate to v2 somehow. It was mostly removed because of some problem discovered in Sherlock if I recall correctly.

[rndquu]

Yeah I think we need to migrate to v2 somehow. It was mostly removed because of some problem discovered in Sherlock if I recall correctly.

Staking contracts weren't part of the Sherlock audit.

[0x4007]

Then I don't remember why some was moved

[rndquu]

Then I don't remember why some was moved

Then perhaps we should reopen this issue?

[0x4007]

It isn't clear to me if we redid the staking yet and if we should migrate? If so perhaps we should make a new issue instead.