Merge pull request #6 from tyx/feature/configurable-wait-for-moco

🔨 Make configurable the tempo to wait for moco

Author: shouze

features/check-moco.feature

@@ -36,5 +36,5 @@ Feature: Check moco
         When I run behat "-f progress features/call_moco.feature"
         Then it should fail with:
             """
-            You should run moco by "bin/moco start -p 9997 -c features/fixtures.yml"
+            Cannot connect to moco on 127.0.0.1 : Connection refused. Ensure to run moco with "bin/moco start -p 9997 -c features/fixtures.yml"
             """

src/MocoWriter.php

@@ -22,8 +22,8 @@ public function __construct($jsonFile, $hostname, $port)
     public function mockHttpCall(array $matchedRequest, array $mockedResponse, array $events = [])
     {
         $entry = [
-            "request" => $matchedRequest,
-            "response" => $mockedResponse
+            'request' => $matchedRequest,
+            'response' => $mockedResponse,
         ];
 
         if (0 < count($events)) {
@@ -33,35 +33,47 @@ public function mockHttpCall(array $matchedRequest, array $mockedResponse, array
         $this->payload[] = $entry;
     }
 
-    public function writeForMoco()
+    public function writeForMoco($maxAttempt = 10, $tempoInMs = 200)
     {
         file_put_contents($this->jsonFile, json_encode($this->payload));
         // We need to wait for moco detecting the fixtures file changed
         // If not, we can perform a request on old configFile
         sleep(1);
-        $this->waitForMoco();
+        $this->waitForMoco($maxAttempt, $tempoInMs);
     }
 
-    public function reset()
+    public function reset($maxAttempt = 10, $tempoInMs = 200)
     {
         $this->payload = [];
         // To avoid false positive by having the next scenario using moco response of the previous scenario
-        $this->writeForMoco();
+        $this->writeForMoco($maxAttempt, $tempoInMs);
     }
 
-    private function waitForMoco()
+    private function waitForMoco($maxAttempt, $tempoInMs)
     {
         $attempts = 0;
-        $max = 10;
         $ip = gethostbyname($this->hostname);
-        while (false === @stream_socket_client('tcp://'.$ip.':'.$this->port, $errno, $errstr, 5) && ($attempts < $max)) {
-            usleep(200000); // 200ms
-            $attempts++;
+        $up = false;
+        while ($attempts < $maxAttempt && false === $up) {
+            $socket = @stream_socket_client('tcp://'.$ip.':'.$this->port, $errno, $errstr, 5);
+
+            if (false === $socket) {
+                usleep($tempoInMs * 1000);
+                ++$attempts;
+            } else {
+                $up = true;
+                @fclose($socket);
+            }
         }
 
-        if ($max <= $attempts) {
+        if ($maxAttempt <= $attempts) {
             throw new \Exception(
-                sprintf('You should run moco by "bin/moco start -p %s -c %s"', $this->port, $this->jsonFile)
+                sprintf('Cannot connect to moco on %s : %s. Ensure to run moco with "bin/moco start -p %s -c %s"',
+                    $ip,
+                    $errstr,
+                    $this->port,
+                    $this->jsonFile
+                )
             );
         }
     }

tests/units/MocoWriter.php

@@ -59,9 +59,49 @@ public function test_it_should_write_events_if_present()
             ->then
                 ->function('file_put_contents')
                     ->wasCalledWithArguments('fixtures.json', json_encode([
-                        ['request' => ['uri' => '/coucou'], 'response' => ['status' => '404'], 'on' => ['complete' => 'ok']]
+                        ['request' => ['uri' => '/coucou'], 'response' => ['status' => '404'], 'on' => ['complete' => 'ok']],
                     ]))
                     ->once()
         ;
     }
+
+    public function test_it_should_try_to_connect_when_first_tries_fail()
+    {
+        $this
+            ->given(
+                $this->newTestedInstance('fixtures.json', '127.0.0.1', '8888'),
+                $this->function->file_put_contents = true,
+                $this->function->stream_socket_client = false,
+                $this->function->stream_socket_client[5] = true,
+                $this->testedInstance->mockHttpCall(['uri' => '/coucou'], ['status' => '404'], ['complete' => 'ok'])
+            )
+            ->when(
+                $this->testedInstance->writeForMoco(5, 1)
+            )
+            ->then
+                ->function('stream_socket_client')
+                    ->wasCalled()
+                    ->exactly(5)
+        ;
+    }
+
+    public function test_it_should_lead_to_exception_when_cannot_connect()
+    {
+        $this
+            ->given(
+                $this->newTestedInstance('fixtures.json', '127.0.0.1', '8888'),
+                $this->function->file_put_contents = true,
+                $this->function->stream_socket_client = false,
+                $this->testedInstance->mockHttpCall(['uri' => '/coucou'], ['status' => '404'], ['complete' => 'ok'])
+            )
+            ->exception(function () {
+                $this->testedInstance->writeForMoco(10, 1);
+            })
+                ->message->contains('Cannot connect to moco')
+            ->then
+                ->function('stream_socket_client')
+                    ->wasCalled()
+                    ->exactly(10)
+        ;
+    }
 }