chore: change default filesystem from btrfs to xfs - #2949
Conversation
3fcf844 to
079ac81
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default filesystem from Btrfs to XFS across the Universal Blue project configuration. The change affects both the bootc installation configuration and the Anaconda installer settings.
Key changes:
- Updates bootc install configuration to use XFS as the root filesystem type
- Modifies Anaconda installer to use XFS instead of Btrfs with updated partitioning scheme
- Removes Btrfs-specific compression settings and partition layout
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| system_files/shared/usr/lib/bootc/install/20-bluefin.toml | Changes root filesystem type from btrfs to xfs |
| iso_files/configure_iso_anaconda.sh | Updates Anaconda installer configuration to use XFS with revised partition scheme |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| / (min 1 GiB, max 70 GiB) | ||
| /home (min 500 MiB, free 50 GiB) | ||
| /var (btrfs) | ||
| /var (min 5 GiB, free 50 GiB) |
There was a problem hiding this comment.
[nitpick] The /var partition configuration appears to have inconsistent spacing. Consider using consistent formatting like '/var (min 5 GiB, free 50 GiB)' to match the / partition format above.
| /var (min 5 GiB, free 50 GiB) | |
| /var (min 5 GiB, free 50 GiB) |
dosubot
Bot
added
size/XS
|
Let's ensure we don't spin any ISOs except to GH artifacts to test, then we can push to cloudflare after some testing. Then we can probably freshen them up at the same time LTS releases. |
Head branch was pushed to by a user without write access
dosubot
Bot
added
size/S
|
You don't need to manually merge in main every time the merge queue would handle that. Ok is this ready? |
Old habits! This is ready yes! |
hanthor
left a comment
hanthor
left a comment
There was a problem hiding this comment.
This looks ready
|
Looks like @castrojo fixed the font failure on main, can we kick off the CI again? |
|
Do we need something else done before we can merge? |
|
We'll need to test this so not keen until closer to F43, we need to finish off LTS and fix bugs before moving on to this. We'll just keep it here queued up. |
|
A good thing to test would be rebasing to LTS from a XFS fedora install. We maybe need to edit the EFI dir. But we might want that to be bluefin anyway, instead of Fedora |
|
Isn't btrfs superior to XFS for a desktop Linux user (and not server)? There are way more bluefin users then bluefin-lts users, so it doesn't make sense to me to change it just for the LTS rebasing use case that most people wouldn't do |
|
Also btrfs recently had regressions in the kernel. RHEL doesn't support for some good reason, etc. Are really this many people using subvolumes? Btrfs isn't going away its just going to be opt-in. People who don't care, won't care and just roll with default XFS. We could to ext4 instead??? |
|
You could easily opt in for btrfs on Anaconda or would you have to resort to manual installation? |
|
Yeah you'd choose manual partitioning and choose btrfs. Can we do some test ISOs to test ahead of time? |
|
We don't have time to test this thoroughly so punting until next cycle. |
|
Even though now closed, I would like to add my 2 cents on the matter: I would rather not change as that will add more maintenance burden on Bluefin devs since, as it is now, the stability is somewhat guaranteed by the Fedora upstream. If it that change does not not add anything "new" regarding functionality - I only see the possibility of moving between Bluefin LTS and Bluefin (GTS) -, I would keep as it is. If it is not broken, do not fix it... |
No description provided.