Skip to content

Commit 431a629

Browse files
authored
Merge pull request #419 from cpaelzer/AA-new-license-check-update-lrc
AA: use lrc for new queue
2 parents 1499a08 + e5bc412 commit 431a629

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

docs/maintainers/AA/aa-new-review.md

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -169,22 +169,14 @@ is in this format, I consider failures to follow the standard to be
169169
reject-level bugs.
170170

171171
The actual process of assessing whether a given package's `debian/copyright` is
172-
correct is a disaster. There should be standard tools, shared between package
173-
maintainers, Debian FTP team, and Ubuntu Archive Admins, that traverse the
174-
source package tree, work out the license and copyright of all files, and
175-
compare that with the contents of a machine-readable `debian/copyright` to see
176-
if they match; with support for a `debian/copyright.overrides` that allows the
177-
maintainer to add declarations when auto-detection of the license/copyright in
178-
the source tree is incorrect.
179-
180-
We don't have that.
181-
182-
Instead, we have `licensecheck -r`, which you can run over the tree of a source
183-
package to get a guess as to the copyright and license, one line per file; and
184-
then you can do *ad hoc* scripting to work out from that output whether
185-
`debian/copyright` matches.
186-
187-
You'd be surprised how often something uploaded to the NEW queue doesn't.
172+
correct is complex - there are standard (not mandatory) and tools (with many
173+
rough edges) to help. The usual approach is to use is {manpage}`lrc(1)`, which
174+
can traverse the source package tree, work out the license and copyright of all
175+
files, and compare that with the contents of a machine-readable
176+
`debian/copyright` to see if they match.
177+
178+
Still there are many false positives, overrides and special cases left, you'd be
179+
surprised how often something uploaded to the NEW queue doesn't match.
188180

189181
Also, it's good to bear in mind the Canonical licensing policy for open source
190182
projects is GPLv3 by default.

0 commit comments

Comments
 (0)