Merge pull request #715 from ucfopen/issue/713-disable-link-rules

Issue/713 disable link rules

Author: bagofarms

.env

@@ -48,7 +48,10 @@ MESSENGER_TRANSPORT_DSN=doctrine://default
 
 ###> phpally ###
 # Rule exclusion list as a comma-separated list of rule IDs.
-PHPALLY_EXCLUDED_RULES=""
+PHPALLY_EXCLUDED_RULES="
+    BrokenLink,
+    RedirectedLink
+"
 # Rules to be treated as suggestions rather than errors. Comma-separated list of rule IDs.
 PHPALLY_SUGGESTION_RULES="
     AnchorLinksToMultiMediaRequireTranscript,

src/Services/PhpAllyService.php

@@ -6,17 +6,17 @@
 use CidiLabs\PhpAlly\PhpAlly;
 
 class PhpAllyService {
-    
+
     protected $phpAlly;
 
     /** @var App\Service\HtmlService */
     protected $htmlService;
 
     protected $util;
-    
+
     public function __construct(HtmlService $htmlService, UtilityService $util)
     {
-        $this->phpAlly = new PhpAlly();    
+        $this->phpAlly = new PhpAlly();
         $this->htmlService = $htmlService;
         $this->util = $util;
     }
@@ -34,7 +34,7 @@ public function scanContentItem(ContentItem $contentItem)
             'vimeoApiKey' => !empty($_ENV['VIMEO_API_KEY']) ? $_ENV['VIMEO_API_KEY'] : '',
             'youtubeApiKey' => !empty($_ENV['YOUTUBE_API_KEY']) ? $_ENV['YOUTUBE_API_KEY'] : ''
         ];
-        
+
         return $this->phpAlly->checkMany($html, $this->getRules(), $options);
     }
 
@@ -52,7 +52,7 @@ public function scanHtml($html, $rules = [])
             'vimeoApiKey' => !empty($_ENV['VIMEO_API_KEY']) ? $_ENV['VIMEO_API_KEY'] : '',
             'youtubeApiKey' => !empty($_ENV['YOUTUBE_API_KEY']) ? $_ENV['YOUTUBE_API_KEY'] : ''
         ];
-        
+
         return $this->phpAlly->checkMany($html, $rules, $options);
     }
 
@@ -68,12 +68,19 @@ public function getRules()
 
     protected function getEnvExcludedRules()
     {
-        return array_map('trim', explode(',', $_ENV['PHPALLY_EXCLUDED_RULES']));
+        $excluded = array_map('trim', explode(',', $_ENV['PHPALLY_EXCLUDED_RULES']));
+
+        return array_map(array($this, 'addRulePath'), $excluded);
     }
 
     protected function getDbExcludedRules()
     {
         // TODO: To be implemented with the admin section
         return [];
     }
-}
+
+    private function addRulePath($rule)
+    {
+        return "CidiLabs\\PhpAlly\\Rule\\" . $rule;
+    }
+}