CTP-6359 Updated mailto subject to course fullname

Author: amandadoughty

classes/output/widgets/contacts.php

@@ -130,8 +130,7 @@ public function get_course_contacts(renderer_base $output): array {
             $contact->role = $c['rolename'];
             $contact->roleshortname = $c['role']->shortname;
             $contact->email = $user->maildisplay == 0 ? null : $user->email;
-            $subject = rawurlencode($course->fullname);
-            $contact->subject = $user->maildisplay == 0 ? null : $subject;
+            $contact->subject = rawurlencode($course->fullname);
 
             // Can the current user edit this contact profile?
             if ($USER->id === $user->id) {

lang/en/format_ucl.php

@@ -58,7 +58,6 @@
 $string['hiddenfromstudents'] = 'Hidden from students';
 $string['hidefromothers'] = 'Hide';
 $string['highlight'] = 'Highlight';
-$string['mailto:subject'] = '{$a->course} - {$a->contactname}';
 $string['messageprovider:expiry'] = 'Expiry message';
 $string['messageprovider:submission'] = 'Submission message';
 $string['name'] = 'Name';

templates/widgets/contacts/contact.mustache

@@ -63,9 +63,11 @@
         <span class="mx-1">{{{name}}}</span>
         {{/custom}}
 
+        {{#email}}
         <a href="mailto:{{{email}}}?subject={{{subject}}}" target="_blank">
             <i class="fa-regular fa-envelope mr-1"></i>{{{email}}}
         </a>
+        {{/email}}
 
         {{#description}}
             <div class="small pt-1">{{{.}}}</div>

templates/widgets/contacts/contacts.mustache

@@ -31,7 +31,9 @@
             {
                 "id": 1,
                 "name": "John Doe",
+                "showemail": true,
                 "email": "john.doe@example.com",
+                "subject": "Course 1",
                 "role": "Teacher",
                 "picture": "<img src='path/to/picture.jpg' alt='John Doe'>",
                 "url": "/user/view.php?id=1",