Skip to content

Commit 0912a30

Browse files
authored
Merge pull request #1591 from bgilbert/pkg-config
pkgconfig: drop unused libraries from `Libs.private`
2 parents e7453e3 + d42966d commit 0912a30

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

CMakeLists.txt

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,13 +328,27 @@ set_variable_from_rel_or_absolute_path("docdir" "\\\${prefix}" "${CMAKE_INSTALL_
328328
set_variable_from_rel_or_absolute_path("libdir" "\\\${prefix}" "${CMAKE_INSTALL_LIBDIR}")
329329
set_variable_from_rel_or_absolute_path("includedir" "\\\${prefix}" "${CMAKE_INSTALL_INCLUDEDIR}/${OPENJPEG_INSTALL_SUBDIR}")
330330

331+
function(get_pkgconfig_deps NAME OUT)
332+
get_target_property(link_libs ${NAME} LINK_LIBRARIES)
333+
if(NOT link_libs STREQUAL "link_libs-NOTFOUND")
334+
foreach(lib ${link_libs})
335+
# omit -lopenjp2 from Libs.private because libopenjp2 is in Requires
336+
if(NOT ${lib} STREQUAL ${OPENJPEG_LIBRARY_NAME})
337+
string(APPEND deps "-l${lib} ")
338+
endif()
339+
endforeach()
340+
endif()
341+
set(${OUT} ${deps} PARENT_SCOPE)
342+
endfunction()
343+
get_pkgconfig_deps(${OPENJPEG_LIBRARY_NAME} deps)
331344
# install in lib and not share (CMAKE_INSTALL_LIBDIR takes care of it for multi-arch)
332345
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/src/lib/openjp2/libopenjp2.pc.cmake.in
333346
${CMAKE_CURRENT_BINARY_DIR}/libopenjp2.pc @ONLY)
334347
install( FILES ${CMAKE_CURRENT_BINARY_DIR}/libopenjp2.pc DESTINATION
335348
${CMAKE_INSTALL_LIBDIR}/pkgconfig )
336349
#
337350
if(BUILD_JPIP)
351+
get_pkgconfig_deps(openjpip deps)
338352
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/src/lib/openjpip/libopenjpip.pc.cmake.in
339353
${CMAKE_CURRENT_BINARY_DIR}/libopenjpip.pc @ONLY)
340354
install( FILES ${CMAKE_CURRENT_BINARY_DIR}/libopenjpip.pc DESTINATION

src/lib/openjp2/libopenjp2.pc.cmake.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ Description: JPEG2000 library (Part 1 and 2)
1010
URL: http://www.openjpeg.org/
1111
Version: @OPENJPEG_VERSION@
1212
Libs: -L${libdir} -lopenjp2
13-
Libs.private: -lm
13+
Libs.private: @deps@
1414
Cflags: -I${includedir}
1515
Cflags.private: -DOPJ_STATIC

src/lib/openjpip/libopenjpip.pc.cmake.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ URL: http://www.openjpeg.org/
1111
Version: @OPENJPEG_VERSION@
1212
Requires: libopenjp2
1313
Libs: -L${libdir} -lopenjpip
14-
Libs.private: -lm -lcurl -lfcgi -lpthread
14+
Libs.private: @deps@
1515
Cflags: -I${includedir}
1616
Cflags.private: -DOPJ_STATIC

0 commit comments

Comments
 (0)